https://bugzilla.redhat.com/show_bug.cgi?id=1268010 --- Comment #2 from Dominique Martinet <dominique.martinet@xxxxxx> --- (In reply to Dave Love from comment #1) > * I don't know if you want to support it, but the Group tag is only > needed for EPEL5; Hmm I'll admit I didn't even try to build on EPEL5, will remove it. > * You normally shouldn't add explicit Requires for dynamic libraries > except typically for devel packages depending on the non-devel > version -- the packaging will usually do that automatically. > For the devel package the Requires should normally be like > > %package devel > Requires: %{name}-libs%{?_isa} = %{version}-%{release} > ... Right, will fix. I think I do need to keep the devel package requirements on other -devel packages, though, right? As far as I can tell (rpm -qpi --requires <package>) it could not guess these, and I couldn't find anything in the guidelines about this. > * make should have an argument %{?_smp_mflags} in the %build section, > or a comment that it's not smp-safe; Ok. > * Don't package .la files (and normally not .a). Under %files, You > can use instead > %exclude %{_libdir}/*a Hmm I wonder why I added the .la there, if anything it should have been in the -devel... But right rhel systems don't even have it, will remove. For the .a though I've pretty much always seen it package in the -devel, but I see the packaging guideline now and it makes sense so I guess I'll strip it off as well. > but you need .so in the devel package, not the main one; Yes, sorry. > * You need to add > > %post -p /sbin/ldconfig > %postun -p /sbin/ldconfig Ok > Sorry not to give references to the packaging guide for each item, but > I hope that helps, and it's easy to fix. Don't be put off! rpmlint > should warn about some of it, and it's worth running fedora-review on > the package (if you can -- I have trouble on an EPEL6 system). No problem, thanks for the review! I'll fix all of that and try fedora-review as soon as I get my laptop back home (might be a few days, will update the ticket with new URLs anyway) Our development servers are behind a kerberized proxy and the fedora tools can't seem to work with that, unfortunately :/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review