[Bug 1263941] Review Request: tayga - Simple out-of-kernel stateless NAT64 daemon

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1263941



--- Comment #4 from Ingvar Hagelund <ingvar@xxxxxxxxx> ---
(In reply to Petr Pisar from comment #3)

Thank you, Petr

Updated src.rpm and specfile here:

http://users.linpro.no/ingvar/tayga/tayga-0.9.2-2.fc22.src.rpm
http://users.linpro.no/ingvar/tayga/tayga.spec

> I suspect the spec file is missing various BuildRequires like coreutils,
> sed, make, gcc for executed commands.

I don't think this is necessary. There is an implicit minimum build system on
all fedora build systems that includes coreutils, binutils, gcc, make, etc. The
packages do build fine in mock and koji without adding these explicitly.

> It should build-require systemd for the %{_unitdir} macro. The %post and
> other scriptlets should run-require chkconfig or systemd respectively. See
> <https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd>.

Fixed

> The COPYING file should be packaged by %license macro instead of the %doc
> macro on Fedora.

Fixed

> I worry that that the LDFLAGS="%{optflags} -pie" ignores default LDFLAGS
> defined by rpmbuild.

Fixed


Ingvar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]