[Bug 1263941] Review Request: tayga - Simple out-of-kernel stateless NAT64 daemon

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1263941

Petr Pisar <ppisar@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ppisar@xxxxxxxxxx



--- Comment #3 from Petr Pisar <ppisar@xxxxxxxxxx> ---
I suspect the spec file is missing various BuildRequires like coreutils, sed,
make, gcc for executed commands.

It should build-require systemd for the %{_unitdir} macro. The %post and other
scriptlets should run-require chkconfig or systemd respectively. See
<https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd>.

The COPYING file should be packaged by %license macro instead of the %doc macro
on Fedora.

I worry that that the LDFLAGS="%{optflags} -pie" ignores default LDFLAGS
defined by rpmbuild.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]