https://bugzilla.redhat.com/show_bug.cgi?id=1263938 --- Comment #2 from Jan Holcapek <holcapek@xxxxxxxxx> --- (In reply to Petr Šabata from comment #1) > * The license is unclear -- while the README file and CPAN metadata claim > the package is distributed under the `perl' license (generally understood as > `GPL+ or Artistic'), the bundled license text is for `Artistic 2.0'. > Please, ask upstream when they really meant. Waiting for their reply. > * %description needs to end with a fullstop. > In your case, consider simple `%{summary}.' > > * Feel free to use the more common DESTDIR rather than PERL_INSTALL_ROOT. > > * Missing build deps ;) > - coreutils, called in spec, line 32 > - findutils, ditto > - make, called in spec, lines 27, 30 and 37 > - perl(IO::Socket::INET), lib/Etsy/StatsD.pm:35 > > * For obvious reasons, the automatic generators won't find that > IO::Socket::INET dependency for you. You'll have to require it explicitly. All above fixed. > * Note: at the moment, the statsd package provides the `perl(Etsy::StatsD)' > symbol. This is a bug. Reported as #1263969. Good catch! Spec URL: https://raw.githubusercontent.com/holcapek/perl-Etsy-StatsD/master/perl-Etsy-StatsD.spec SRPM URL: https://github.com/holcapek/perl-Etsy-StatsD/raw/master/perl-Etsy-StatsD-1.001-2.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review