[Bug 1263938] Review Request: perl-Etsy-StatsD - Object-Oriented Client for Etsy's StatsD Server

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1263938



--- Comment #1 from Petr Šabata <psabata@xxxxxxxxxx> ---
* The license is unclear -- while the README file and CPAN metadata claim the
package is distributed under the `perl' license (generally understood as `GPL+
or Artistic'), the bundled license text is for `Artistic 2.0'.  Please, ask
upstream when they really meant.

* %description needs to end with a fullstop.
  In your case, consider simple `%{summary}.'

* Feel free to use the more common DESTDIR rather than PERL_INSTALL_ROOT.

* Missing build deps ;)
  - coreutils, called in spec, line 32
  - findutils, ditto
  - make, called in spec, lines 27, 30 and 37
  - perl(IO::Socket::INET), lib/Etsy/StatsD.pm:35

* For obvious reasons, the automatic generators won't find that
IO::Socket::INET dependency for you.  You'll have to require it explicitly.

* Note: at the moment, the statsd package provides the `perl(Etsy::StatsD)'
symbol.  This is a bug.  Reported as #1263969.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]