[Bug 1264546] Review Request: soletta - A framework for making IoT devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1264546

Piotr Popieluch <piotr1212@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |piotr1212@xxxxxxxxx



--- Comment #8 from Piotr Popieluch <piotr1212@xxxxxxxxx> ---
> Sorry, indeed the 0 one was wrong. What's the point of github having the 
> downloaded file != the URL file? :/

"spectool -g x.spec" downloads the sources. 

Most reviewers also use "fedora-review -b 1264546" for reviews, this also
checks the source urls. 

fedora-review fails to build, could you please run fedora-review yourself first
and fix the issues.

There are also guidelines on the Source, please see this section for the source
packaging guidelines:
https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Git_Hosting_Services

I don't fully understand the release of the package. Release: tag should
specifies the  release of the package, eg. you update the specfile and should
increment the release by one. It seems to me that you filled in upstreams
release, which should be part of version.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]