https://bugzilla.redhat.com/show_bug.cgi?id=1263008 Lubomir Rintel <lrintel@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lrintel@xxxxxxxxxx --- Comment #2 from Lubomir Rintel <lrintel@xxxxxxxxxx> --- (In reply to Christopher Meng from comment #1) > 1. %{_sysconfdir}/openfortivpn/config > > %config()? Fixed. > 2. ppp plugin directory is versioned, it's better to use > > Requires: ppp = $ppp_ver > > or some others. We don't install a ppp plugin. > 3. You miswrote Source0. No, it's the one I intended to package. They're going to merge soon, I'll then just switch it to the original one instead of the forked one. This just seemed nicer that a pile-o-patches. > Ok for swap review? Sure, let me know which one you'd like me to review. SPEC: http://v3.sk/~lkundrak/SPECS/openfortivpn.spec SRPM: http://v3.sk/~lkundrak/SRPMS/openfortivpn-1.0.1-2.20150914gitb22d9eb.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review