[Bug 804125] Review Request: rdkit - A toolkit for cheminformatics and machine learning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=804125

Christopher Meng <i@xxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(i@xxxxxxxx)       |



--- Comment #37 from Christopher Meng <i@xxxxxxxx> ---
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated



Issues:
=======
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file license.txt is marked as %doc instead of %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "MIT/X11 (BSD like)", "BSL (v1.0)",
     "BSL", "BSD (3 clause)", "BSD (2 clause)". 1049 files have unknown
     license. Detailed output of licensecheck:

See attachment.

[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 133120 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: Uses parallel make %{?_smp_mflags} macro.
[x]: Avoid bundling fonts in non-fonts packages.
     Note: Package contains font files
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rdkit-
     doc , rdkit-extras , rdkit-debuginfo
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Scriptlets must be sane, if used.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[-]: Rpmlint is run on all installed packages.
     Note: Mock build failed
     See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.


Installation errors
-------------------
INFO: mock.py version 1.2.12 starting (python version = 3.4.3)...
Start: init plugins
INFO: selinux disabled
Finish: init plugins
Start: run
Start: chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled dnf cache
Start: cleaning dnf metadata
Finish: cleaning dnf metadata
INFO: enabled ccache
Mock Version: 1.2.12
INFO: Mock Version: 1.2.12
Finish: chroot init
INFO: installing package(s):
/home/rpmaker/Desktop/rdkit/results/rdkit-2015.03.1-2.fc24.i686.rpm
/home/rpmaker/Desktop/rdkit/results/rdkit-devel-2015.03.1-2.fc24.i686.rpm
/home/rpmaker/Desktop/rdkit/results/rdkit-doc-2015.03.1-2.fc24.noarch.rpm
/home/rpmaker/Desktop/rdkit/results/rdkit-extras-2015.03.1-2.fc24.noarch.rpm
/home/rpmaker/Desktop/rdkit/results/python-rdkit-2015.03.1-2.fc24.i686.rpm
/home/rpmaker/Desktop/rdkit/results/rdkit-postgresql-2015.03.1-2.fc24.i686.rpm
/home/rpmaker/Desktop/rdkit/results/rdkit-debuginfo-2015.03.1-2.fc24.i686.rpm
/home/rpmaker/Desktop/rdkit/results/rdkit-debuginfo-2015.03.1-2.fc24.i686.rpm
ERROR: Command failed. See logs for output.
 # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-i386/root/
--releasever 24 install
/home/rpmaker/Desktop/rdkit/results/rdkit-2015.03.1-2.fc24.i686.rpm
/home/rpmaker/Desktop/rdkit/results/rdkit-devel-2015.03.1-2.fc24.i686.rpm
/home/rpmaker/Desktop/rdkit/results/rdkit-doc-2015.03.1-2.fc24.noarch.rpm
/home/rpmaker/Desktop/rdkit/results/rdkit-extras-2015.03.1-2.fc24.noarch.rpm
/home/rpmaker/Desktop/rdkit/results/python-rdkit-2015.03.1-2.fc24.i686.rpm
/home/rpmaker/Desktop/rdkit/results/rdkit-postgresql-2015.03.1-2.fc24.i686.rpm
/home/rpmaker/Desktop/rdkit/results/rdkit-debuginfo-2015.03.1-2.fc24.i686.rpm
/home/rpmaker/Desktop/rdkit/results/rdkit-debuginfo-2015.03.1-2.fc24.i686.rpm


Rpmlint
-------
Checking: rdkit-2015.03.1-2.fc24.i686.rpm
          rdkit-devel-2015.03.1-2.fc24.i686.rpm
          rdkit-doc-2015.03.1-2.fc24.noarch.rpm
          rdkit-extras-2015.03.1-2.fc24.noarch.rpm
          python-rdkit-2015.03.1-2.fc24.i686.rpm
          rdkit-postgresql-2015.03.1-2.fc24.i686.rpm
          rdkit-debuginfo-2015.03.1-2.fc24.i686.rpm
          rdkit-2015.03.1-2.fc24.src.rpm
rdkit.i686: W: spelling-error Summary(en_US) informatics -> information,
informative, informants
rdkit.i686: W: spelling-error %description -l en_US informatics -> information,
informative, informants
rdkit.i686: W: shared-lib-calls-exit /usr/lib/libSmilesParse.so.1.2015.03.1
exit@GLIBC_2.0
rdkit.i686: W: shared-lib-calls-exit /usr/lib/libSLNParse.so.1.2015.03.1
exit@GLIBC_2.0
rdkit-devel.i686: W: no-documentation
rdkit-doc.noarch: W: no-documentation
rdkit-extras.noarch: W: no-documentation
rdkit-extras.noarch: W: devel-file-in-non-devel-package
/usr/share/RDKit/Contrib/ConformerParser/test.cpp
rdkit-extras.noarch: W: devel-file-in-non-devel-package
/usr/share/RDKit/Contrib/ConformerParser/ConformerParser.h
rdkit-extras.noarch: W: devel-file-in-non-devel-package
/usr/share/RDKit/Contrib/ConformerParser/ConformerParser.cpp
rdkit-extras.noarch: W: devel-file-in-non-devel-package
/usr/share/RDKit/Contrib/PBF/PBFRDKit.h
rdkit-extras.noarch: E: non-executable-script
/usr/share/RDKit/Contrib/fraggle/cxn_tversky.py 644 /usr/bin/env
rdkit-extras.noarch: W: devel-file-in-non-devel-package
/usr/share/RDKit/Contrib/PBF/demo.cpp
rdkit-extras.noarch: W: devel-file-in-non-devel-package
/usr/share/RDKit/Contrib/PBF/PBFRDKit.cpp
rdkit-extras.noarch: W: devel-file-in-non-devel-package
/usr/share/RDKit/Contrib/ConformerParser/Wrap/rdConformerParser.cpp
python-rdkit.i686: W: no-documentation
python-rdkit.i686: E: non-executable-script
/usr/lib/python2.7/site-packages/rdkit/Chem/fmcs/fmcs 644 /usr/bin/env
python-rdkit.i686: E: non-executable-script
/usr/lib/python2.7/site-packages/rdkit/Chem/fmcs/fmcs.py 644 /usr/bin/env
rdkit-postgresql.i686: W: spelling-error %description -l en_US mol -> mewl,
mil, mo
rdkit-postgresql.i686: W: spelling-error %description -l en_US fp -> pf, f, p
rdkit-postgresql.i686: W: spelling-error %description -l en_US tanimoto ->
animator
rdkit-debuginfo.i686: W: spurious-executable-perm
/usr/src/debug/rdkit-Release_2015_03_1/Code/Numerics/Optimizer/BFGSOpt.h
rdkit-debuginfo.i686: W: spurious-executable-perm
/usr/src/debug/rdkit-Release_2015_03_1/Code/GraphMol/Wrap/MolOps.cpp
rdkit.src: W: spelling-error Summary(en_US) informatics -> information,
informative, informants
rdkit.src: W: spelling-error %description -l en_US informatics -> information,
informative, informants
rdkit.src: W: patch-not-applied Patch5: rdkit-2014.09-allow_system_junit.patch
8 packages and 0 specfiles checked; 3 errors, 23 warnings.




Requires
--------
rdkit-debuginfo (rpmlib, GLIBC filtered):

rdkit (rpmlib, GLIBC filtered):
    /sbin/ldconfig
    libAlignment.so.1
    libCatalogs.so.1
    libChemTransforms.so.1
    libDataStructs.so.1
    libDepictor.so.1
    libDescriptors.so.1
    libDistGeometry.so.1
    libEigenSolvers.so.1
    libFileParsers.so.1
    libFingerprints.so.1
    libForceField.so.1
    libForceFieldHelpers.so.1
    libGraphMol.so.1
    libMolTransforms.so.1
    libOptimizer.so.1
    libPartialCharges.so.1
    libRDGeneral.so.1
    libRDGeometryLib.so.1
    libSmilesParse.so.1
    libSubgraphs.so.1
    libSubstructMatch.so.1
    libboost_python.so.1.59.0
    libboost_regex.so.1.59.0
    libc.so.6
    libgcc_s.so.1
    libgcc_s.so.1(GCC_3.0)
    libhc.so.1
    libinchi.so.1
    libm.so.6
    libpthread.so.0
    libpython2.7.so.1.0
    libstdc++.so.6
    libstdc++.so.6(CXXABI_1.3)
    libstdc++.so.6(CXXABI_1.3.1)
    rtld(GNU_HASH)

rdkit-devel (rpmlib, GLIBC filtered):
    boost-devel
    cmake
    libAlignment.so.1
    libCatalogs.so.1
    libChemReactions.so.1
    libChemTransforms.so.1
    libChemicalFeatures.so.1
    libDataStructs.so.1
    libDepictor.so.1
    libDescriptors.so.1
    libDistGeomHelpers.so.1
    libDistGeometry.so.1
    libEigenSolvers.so.1
    libFMCS.so.1
    libFileParsers.so.1
    libFingerprints.so.1
    libForceField.so.1
    libForceFieldHelpers.so.1
    libFragCatalog.so.1
    libGraphMol.so.1
    libInfoTheory.so.1
    libMolAlign.so.1
    libMolCatalog.so.1
    libMolChemicalFeatures.so.1
    libMolDraw2D.so.1
    libMolHash.so.1
    libMolTransforms.so.1
    libOptimizer.so.1
    libPartialCharges.so.1
    libRDBoost.so.1
    libRDGeneral.so.1
    libRDGeometryLib.so.1
    libRDInchiLib.so.1
    libSLNParse.so.1
    libShapeHelpers.so.1
    libSimDivPickers.so.1
    libSmilesParse.so.1
    libSubgraphs.so.1
    libSubstructMatch.so.1
    libhc.so.1
    python2-devel
    rdkit(x86-32)

rdkit-postgresql (rpmlib, GLIBC filtered):
    libChemReactions.so.1
    libChemTransforms.so.1
    libDataStructs.so.1
    libDepictor.so.1
    libDescriptors.so.1
    libFMCS.so.1
    libFileParsers.so.1
    libFingerprints.so.1
    libGraphMol.so.1
    libMolHash.so.1
    libRDGeneral.so.1
    libSmilesParse.so.1
    libSubstructMatch.so.1
    libc.so.6
    libgcc_s.so.1
    libgcc_s.so.1(GCC_3.0)
    libm.so.6
    libstdc++.so.6
    libstdc++.so.6(CXXABI_1.3)
    postgresql-server
    rdkit(x86-32)
    rtld(GNU_HASH)

rdkit-extras (rpmlib, GLIBC filtered):
    /usr/bin/python
    rdkit

python-rdkit (rpmlib, GLIBC filtered):
    libAlignment.so.1
    libCatalogs.so.1
    libChemReactions.so.1
    libChemTransforms.so.1
    libChemicalFeatures.so.1
    libDataStructs.so.1
    libDepictor.so.1
    libDescriptors.so.1
    libDistGeomHelpers.so.1
    libDistGeometry.so.1
    libEigenSolvers.so.1
    libFMCS.so.1
    libFileParsers.so.1
    libFingerprints.so.1
    libForceField.so.1
    libForceFieldHelpers.so.1
    libFragCatalog.so.1
    libGraphMol.so.1
    libInfoTheory.so.1
    libMolAlign.so.1
    libMolCatalog.so.1
    libMolChemicalFeatures.so.1
    libMolDraw2D.so.1
    libMolHash.so.1
    libMolTransforms.so.1
    libOptimizer.so.1
    libPartialCharges.so.1
    libRDBoost.so.1
    libRDGeneral.so.1
    libRDGeometryLib.so.1
    libRDInchiLib.so.1
    libSLNParse.so.1
    libShapeHelpers.so.1
    libSimDivPickers.so.1
    libSmilesParse.so.1
    libSubgraphs.so.1
    libSubstructMatch.so.1
    libboost_python.so.1.59.0
    libboost_regex.so.1.59.0
    libc.so.6
    libgcc_s.so.1
    libgcc_s.so.1(GCC_3.0)
    libhc.so.1
    libinchi.so.1
    libm.so.6
    libpthread.so.0
    libpython2.7.so.1.0
    libstdc++.so.6
    libstdc++.so.6(CXXABI_1.3)
    libstdc++.so.6(CXXABI_1.3.1)
    numpy
    pycairo
    python(abi)
    python-imaging
    rdkit(x86-32)
    rtld(GNU_HASH)
    xorg-x11-fonts-Type1

rdkit-doc (rpmlib, GLIBC filtered):
    rdkit



Provides
--------
rdkit-debuginfo:
    rdkit-debuginfo
    rdkit-debuginfo(x86-32)

rdkit:
    libAlignment.so.1
    libCatalogs.so.1
    libChemReactions.so.1
    libChemTransforms.so.1
    libChemicalFeatures.so.1
    libDataStructs.so.1
    libDepictor.so.1
    libDescriptors.so.1
    libDistGeomHelpers.so.1
    libDistGeometry.so.1
    libEigenSolvers.so.1
    libFMCS.so.1
    libFileParsers.so.1
    libFingerprints.so.1
    libForceField.so.1
    libForceFieldHelpers.so.1
    libFragCatalog.so.1
    libGraphMol.so.1
    libInfoTheory.so.1
    libMolAlign.so.1
    libMolCatalog.so.1
    libMolChemicalFeatures.so.1
    libMolDraw2D.so.1
    libMolHash.so.1
    libMolTransforms.so.1
    libOptimizer.so.1
    libPartialCharges.so.1
    libRDBoost.so.1
    libRDGeneral.so.1
    libRDGeometryLib.so.1
    libRDInchiLib.so.1
    libSLNParse.so.1
    libShapeHelpers.so.1
    libSimDivPickers.so.1
    libSmilesParse.so.1
    libSubgraphs.so.1
    libSubstructMatch.so.1
    libhc.so.1
    rdkit
    rdkit(x86-32)

rdkit-devel:
    rdkit-devel
    rdkit-devel(x86-32)

rdkit-postgresql:
    rdkit-postgresql
    rdkit-postgresql(x86-32)

rdkit-extras:
    rdkit-extras

python-rdkit:
    python-rdkit
    python-rdkit(x86-32)

rdkit-doc:
    rdkit-doc



Unversioned so-files
--------------------
python-rdkit: /usr/lib/python2.7/site-packages/rdkit/Chem/Draw/rdMolDraw2D.so
python-rdkit: /usr/lib/python2.7/site-packages/rdkit/Chem/rdChemReactions.so
python-rdkit: /usr/lib/python2.7/site-packages/rdkit/Chem/rdChemicalFeatures.so
python-rdkit: /usr/lib/python2.7/site-packages/rdkit/Chem/rdDepictor.so
python-rdkit: /usr/lib/python2.7/site-packages/rdkit/Chem/rdDistGeom.so
python-rdkit: /usr/lib/python2.7/site-packages/rdkit/Chem/rdFMCS.so
python-rdkit:
/usr/lib/python2.7/site-packages/rdkit/Chem/rdForceFieldHelpers.so
python-rdkit: /usr/lib/python2.7/site-packages/rdkit/Chem/rdMolAlign.so
python-rdkit: /usr/lib/python2.7/site-packages/rdkit/Chem/rdMolCatalog.so
python-rdkit:
/usr/lib/python2.7/site-packages/rdkit/Chem/rdMolChemicalFeatures.so
python-rdkit: /usr/lib/python2.7/site-packages/rdkit/Chem/rdMolDescriptors.so
python-rdkit: /usr/lib/python2.7/site-packages/rdkit/Chem/rdMolHash.so
python-rdkit: /usr/lib/python2.7/site-packages/rdkit/Chem/rdMolTransforms.so
python-rdkit: /usr/lib/python2.7/site-packages/rdkit/Chem/rdPartialCharges.so
python-rdkit: /usr/lib/python2.7/site-packages/rdkit/Chem/rdSLNParse.so
python-rdkit: /usr/lib/python2.7/site-packages/rdkit/Chem/rdShapeHelpers.so
python-rdkit: /usr/lib/python2.7/site-packages/rdkit/Chem/rdchem.so
python-rdkit: /usr/lib/python2.7/site-packages/rdkit/Chem/rdfragcatalog.so
python-rdkit: /usr/lib/python2.7/site-packages/rdkit/Chem/rdinchi.so
python-rdkit: /usr/lib/python2.7/site-packages/rdkit/Chem/rdmolfiles.so
python-rdkit: /usr/lib/python2.7/site-packages/rdkit/Chem/rdmolops.so
python-rdkit: /usr/lib/python2.7/site-packages/rdkit/Chem/rdqueries.so
python-rdkit:
/usr/lib/python2.7/site-packages/rdkit/DataManip/Metric/rdMetricMatrixCalc.so
python-rdkit:
/usr/lib/python2.7/site-packages/rdkit/DataStructs/cDataStructs.so
python-rdkit:
/usr/lib/python2.7/site-packages/rdkit/DistanceGeometry/DistGeom.so
python-rdkit: /usr/lib/python2.7/site-packages/rdkit/ForceField/rdForceField.so
python-rdkit: /usr/lib/python2.7/site-packages/rdkit/Geometry/rdGeometry.so
python-rdkit: /usr/lib/python2.7/site-packages/rdkit/ML/Cluster/Clustering.so
python-rdkit: /usr/lib/python2.7/site-packages/rdkit/ML/Data/cQuantize.so
python-rdkit:
/usr/lib/python2.7/site-packages/rdkit/ML/InfoTheory/rdInfoTheory.so
python-rdkit: /usr/lib/python2.7/site-packages/rdkit/Numerics/rdAlignment.so
python-rdkit:
/usr/lib/python2.7/site-packages/rdkit/SimDivFilters/rdSimDivPickers.so
python-rdkit: /usr/lib/python2.7/site-packages/rdkit/rdBase.so
rdkit-postgresql: /usr/lib/pgsql/rdkit.so

Source checksums
----------------
https://github.com/rdkit/rdkit/archive/Release_2015_03_1.tar.gz :
  CHECKSUM(SHA256) this package     :
48da4cb234c892893b89001aeb365038a2ab5d308fd893eb2834ef2cab6b3074
  CHECKSUM(SHA256) upstream package :
48da4cb234c892893b89001aeb365038a2ab5d308fd893eb2834ef2cab6b3074


Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -rvn rdkit-2015.03.1-2.fc21.src.rpm
Buildroot used: fedora-rawhide-i386
Active plugins: Python, Generic, Shell-api, C/C++
Disabled plugins: Java, SugarActivity, fonts, Haskell, Ocaml, Perl, R, PHP,
Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
--------------------

1. Fix rpmlint W issues, like wrong perms, wrong env shebangs. Note that please
patch python interpreter to %{__python2}.

2. use confitional block for tests BRs, to avoid pulling in redundant deps.

3. 
BuildRequires:  cmake
BuildRequires:  flex
BuildRequires:  bison
BuildRequires:  python2-devel
BuildRequires:  boost-devel >= 1.39
BuildRequires:  postgresql-devel
BuildRequires:  %{_bindir}/pg_config
BuildRequires:  numpy
BuildRequires:  inchi-devel
BuildRequires:  chrpath
BuildRequires:  swig
BuildRequires:  java-1.8.0-openjdk-devel
BuildRequires:  junit

i. Drop version requirement in BuildRequires:  boost-devel >= 1.39, it's too
old.

ii. BuildRequires:  java-1.8.0-openjdk-devel -> BuildRequires:  java-devel

iii. Requires:       cmake in -devel is wrong, do not pull cmake as dep just
because it ships some cmake modules. Drop it and %dir in %files.

iv. 

-devel:

Requires:       python2-devel
Requires:       boost-devel

-postgresql:

Requires:       postgresql-server

-python-rdkit
Requires:       numpy

Are you sure rdkit-devel needs python2-devel? ALSO, use %{?_isa} in

Requires:       PKGNAME-devel%{?_isa}

for devel deps.

4. %license instead: %doc license.txt. I don't care if you want to build it for
EPEL6, please add it to conform to Fedora guidelines.

5. 
To complete installation of the cartridge in PostgreSQL, please follow
the steps detailed in:

%{_pkgdocdir}/README

it doesn't work, it will point to main package's dir instead of -postgresql's
dir. Use full path.

6. 

`# Test fails as of 2015.03 release, upstream contacted to try resolve the
issue`

Not enough, please write down github issue link or some details.

7. -doc:

/usr/share/RDKit/Docs/Book/exts/

Include PDF ONLY. (Generated for 2013.9 release, probably dated, you can
generate from source again, requires additional deps)

Also, %doc RDKit.pdf.

8. Broken script: %{buildroot}/%{_prefix}/src?

9. Summary:        A toolkit for chemical informatics and machine learning 

->

Summary:        Chemical informatics and machine learning toolkit

10. Python3 wrapper please.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]