https://bugzilla.redhat.com/show_bug.cgi?id=1223673 --- Comment #11 from Milan Bouchet-Valat <nalimilan@xxxxxxx> --- (In reply to Jens Petersen from comment #10) > > > [!]: %build honors applicable compiler flags or justifies otherwise. > > > Could you add a comment explaining why %{optflags} is ignored > > > and why --with-optimize-option=-O3 is a good idea? > > > > Okay > > I think %configure should setup to %{optflags}. Are you saying > it is not working or sufficient here? Ah, right. > -O3 just comes from llvm.spec - I can try to track down why it is there. Yes, a small comment wouldn't hurt. I think the guidelines say that -03 should generally be avoided unless you can be sure it really improves performance. > > > [!]: Patches link to upstream bugs/comments/lists or are otherwise > > > justified. > > > Could use a bit more verbose comments and links to upstream patches. > > Ideally yes :) > Good to file a bug against llvm perhaps. Yes, yet another thing to fix first in llvm. Do you want to upload a new version so that I can approve the package? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review