[Bug 1223673] Review Request: llvm35 - The Low Level Virtual Machine

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1223673



--- Comment #10 from Jens Petersen <petersen@xxxxxxxxxx> ---
> > [!]: %build honors applicable compiler flags or justifies otherwise.
> >      Could you add a comment explaining why %{optflags} is ignored
> >      and why --with-optimize-option=-O3 is a good idea?
> 
> Okay

I think %configure should setup to %{optflags}.  Are you saying
it is not working or sufficient here?

-O3 just comes from llvm.spec - I can try to track down why it is there.

> > [!]: Patches link to upstream bugs/comments/lists or are otherwise
> >      justified.
> >      Could use a bit more verbose comments and links to upstream patches.

Ideally yes :)
Good to file a bug against llvm perhaps.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]