[Bug 1256435] Review Request: metapixel - photomosaic generator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1256435

Miroslav Suchý <msuchy@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(msuchy@xxxxxxxxxx |
                   |)                           |



--- Comment #8 from Miroslav Suchý <msuchy@xxxxxxxxxx> ---
SPEC in #7 differs from SPEC file included in SRPM in #7.

> %{_mandir}/man1/metapixel.1
This should be:
%{_mandir}/man1/metapixel.1*

> Requires: libpng
> Requires: libjpeg
> Requires: giflib

This is not needed. Rpm automatically guess this dependency and generate e.g
for libjpeg those deps:
  libjpeg.so.62()(64bit)
  libjpeg.so.62(LIBJPEG_6.2)(64bit)
which is more precise than listing libjpeg explicitely.

>%changelog
> * Wed Aug 26 2015 Neil Horman <nhorman@xxxxxxxxxxxxx> - 1.0.2

As I said, you should user release in changelog entry as well. Therefore:
* Wed Aug 26 2015 Neil Horman <nhorman@xxxxxxxxxxxxx> - 1.0.2-1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]