https://bugzilla.redhat.com/show_bug.cgi?id=755510 Jens Lody <fedora@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxxx --- Comment #85 from Jens Lody <fedora@xxxxxxxxxxx> --- Informal review: >From a quick look: you need to run glib-compile-schemas in %postun and %posstrans, except for most recent rawhide with file-triggers, see my review-request: https://bugzilla.redhat.com/show_bug.cgi?id=1246903 . Running glib-compile-schemas in %build is most likely unneeded. You just need to install the xml.file in the the systems schemas-folder. You need to reflect the mixed licenses in the License-tag and add ann additional comment: e.g. "# The entire source code is GPLv3+ except convenience.js, which is BSD\nLicense: GPLv3+ and BSD" . Two javascript-files and the two shell-scripts are without a license-header, this might be okay, but probably it should be stated explicitely in the license-file (COPYING). AN upstream is probably the best idea to get rid of this problem. cleaning the buildroot is not needed and shuld not be doen (except for older EPEL), The schams subfolder in the shell-extensions directory is not needed (just for local installs below "~/.local" . You do not own the shell-extensions folder, see also my review-request for this issue and a solution. I think the %if-clause at the top of the spec-file is not needed any longer, because FC17 has reached EOL several years ago. That's all after a quick look. I try to look into it deeper after coming back from work. Jens -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review