https://bugzilla.redhat.com/show_bug.cgi?id=1246846 --- Comment #5 from gil cattaneo <puntogil@xxxxxxxxx> --- (In reply to Jonny Heggheim from comment #4) > [x]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses > found: "BSD (3 clause)", "GPL (v2)", "Unknown or generated". 2 files > have unknown license. > jmh-65fdc5d5f65d/jmh-core/src/main/java/org/openjdk/jmh/annotations/ > Benchmark.java > jmh-65fdc5d5f65d/jmh-core/src/main/java/org/openjdk/jmh/profile/ > WinPerfAsmProfiler.java > > Please contact upstream to clarify licensing. Best if they put proper > license header and release new version. Done. I await the reply by jmh mail list. http://mail.openjdk.java.net/pipermail/jmh-dev/2015-August/002037.html I am not aware of where their bug tracker ... :( > [x]: License file installed when any subpackage combination is installed. > [!]: If the package is under multiple licenses, the licensing breakdown > must be documented in the spec. > All packages are GPL, except samples that is BSD Already documented (near the license field) > [!]: Package requires other packages for directories it uses. > Note: No known owner of /usr/share/maven-poms/jmh, /usr/share/java/jmh > [!]: Package must own all directories that it creates. > Note: Directories without known owners: /usr/share/java/jmh, > /usr/share/maven-poms/jmh This package is for rawhide (at most for f23). in these 2 branches these directories should be handled by our java tools and do not need to add extra owned directories. see file.dir file if you use fedora >= 22 in the 1246846-jmh folder > This is my second review. Overall good package, I would also consider moving > the Maven metadata in jmh-parent into jmh-core (like how jsch-agent-proxy > does it) If is not a problem i prefer leave as is -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review