https://bugzilla.redhat.com/show_bug.cgi?id=1246846 --- Comment #4 from Jonny Heggheim <hegjon@xxxxxxxxx> --- ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "GPL (v2)", "Unknown or generated". 2 files have unknown license. jmh-65fdc5d5f65d/jmh-core/src/main/java/org/openjdk/jmh/annotations/Benchmark.java jmh-65fdc5d5f65d/jmh-core/src/main/java/org/openjdk/jmh/profile/WinPerfAsmProfiler.java Please contact upstream to clarify licensing. Best if they put proper license header and release new version. [x]: License file installed when any subpackage combination is installed. [!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. All packages are GPL, except samples that is BSD [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/maven-poms/jmh, /usr/share/java/jmh [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/java/jmh, /usr/share/maven-poms/jmh [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build [x]: Packages have proper BuildRequires/Requires on jpackage-utils Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Maven: [x]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: POM files have correct Maven mapping [x]: Maven packages should use new style packaging [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in jmh- core-benchmarks , jmh-core-ct , jmh-core-it , jmh-generator-annprocess , jmh-generator-asm , jmh-generator-bytecode , jmh-generator- reflection , jmh-parent , jmh-samples , jmh-javadoc [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Java: [x]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: jmh-1.10.4-1.fc22.noarch.rpm jmh-core-benchmarks-1.10.4-1.fc22.noarch.rpm jmh-core-ct-1.10.4-1.fc22.noarch.rpm jmh-core-it-1.10.4-1.fc22.noarch.rpm jmh-generator-annprocess-1.10.4-1.fc22.noarch.rpm jmh-generator-asm-1.10.4-1.fc22.noarch.rpm jmh-generator-bytecode-1.10.4-1.fc22.noarch.rpm jmh-generator-reflection-1.10.4-1.fc22.noarch.rpm jmh-parent-1.10.4-1.fc22.noarch.rpm jmh-samples-1.10.4-1.fc22.noarch.rpm jmh-javadoc-1.10.4-1.fc22.noarch.rpm jmh-1.10.4-1.fc22.src.rpm jmh.noarch: W: spelling-error %description -l en_US analysing -> analyzing, analysis, signaling jmh.noarch: W: spelling-error %description -l en_US nano -> anon, Kano, Nona jmh.noarch: W: no-documentation jmh-core-benchmarks.noarch: W: no-documentation jmh-core-ct.noarch: W: no-documentation jmh-core-it.noarch: W: no-documentation jmh-generator-annprocess.noarch: W: no-documentation jmh-generator-asm.noarch: W: spelling-error %description -l en_US bytecode -> byte code, byte-code, decorate jmh-generator-asm.noarch: W: no-documentation jmh-generator-bytecode.noarch: W: no-documentation jmh-generator-reflection.noarch: W: no-documentation jmh-parent.noarch: W: no-documentation jmh-samples.noarch: W: no-documentation jmh.src: W: spelling-error %description -l en_US analysing -> analyzing, analysis, signaling jmh.src: W: spelling-error %description -l en_US nano -> anon, Kano, Nona 12 packages and 0 specfiles checked; 0 errors, 15 warnings. Rpmlint (installed packages) ---------------------------- jmh-core-ct.noarch: W: no-documentation jmh-generator-asm.noarch: W: spelling-error %description -l en_US bytecode -> byte code, byte-code, decorate jmh-generator-asm.noarch: W: no-documentation jmh-samples.noarch: W: no-documentation jmh-generator-bytecode.noarch: W: no-documentation jmh.noarch: W: spelling-error %description -l en_US analysing -> analyzing, analysis, signaling jmh.noarch: W: spelling-error %description -l en_US nano -> anon, Kano, Nona jmh.noarch: W: no-documentation jmh-core-it.noarch: W: no-documentation jmh-generator-reflection.noarch: W: no-documentation jmh-generator-annprocess.noarch: W: no-documentation jmh-parent.noarch: W: no-documentation jmh-core-benchmarks.noarch: W: no-documentation 11 packages and 0 specfiles checked; 0 errors, 13 warnings. Requires -------- jmh-core-ct (rpmlib, GLIBC filtered): java-headless jpackage-utils mvn(org.openjdk.jmh:jmh-core) mvn(org.openjdk.jmh:jmh-generator-annprocess) mvn(org.openjdk.jmh:jmh-generator-asm) mvn(org.openjdk.jmh:jmh-generator-reflection) jmh-generator-asm (rpmlib, GLIBC filtered): java-headless jpackage-utils mvn(org.openjdk.jmh:jmh-core) mvn(org.openjdk.jmh:jmh-generator-reflection) mvn(org.ow2.asm:asm) jmh-javadoc (rpmlib, GLIBC filtered): jpackage-utils jmh-samples (rpmlib, GLIBC filtered): java-headless jpackage-utils mvn(org.openjdk.jmh:jmh-core) jmh-generator-bytecode (rpmlib, GLIBC filtered): java-headless jpackage-utils mvn(org.openjdk.jmh:jmh-core) mvn(org.openjdk.jmh:jmh-generator-asm) mvn(org.openjdk.jmh:jmh-generator-reflection) jmh (rpmlib, GLIBC filtered): java-headless jpackage-utils mvn(net.sf.jopt-simple:jopt-simple) mvn(org.apache.commons:commons-math3) jmh-core-it (rpmlib, GLIBC filtered): java-headless jpackage-utils mvn(org.openjdk.jmh:jmh-core) jmh-generator-reflection (rpmlib, GLIBC filtered): java-headless jpackage-utils mvn(org.openjdk.jmh:jmh-core) jmh-generator-annprocess (rpmlib, GLIBC filtered): java-headless jpackage-utils mvn(org.openjdk.jmh:jmh-core) jmh-parent (rpmlib, GLIBC filtered): java-headless jpackage-utils mvn(org.apache.maven.plugins:maven-javadoc-plugin) jmh-core-benchmarks (rpmlib, GLIBC filtered): java-headless jpackage-utils mvn(org.openjdk.jmh:jmh-core) Provides -------- jmh-core-ct: jmh-core-ct mvn(org.openjdk.jmh:jmh-core-ct) mvn(org.openjdk.jmh:jmh-core-ct:pom:) jmh-generator-asm: jmh-generator-asm mvn(org.openjdk.jmh:jmh-generator-asm) mvn(org.openjdk.jmh:jmh-generator-asm:pom:) jmh-javadoc: jmh-javadoc jmh-samples: jmh-samples mvn(org.openjdk.jmh:jmh-samples) mvn(org.openjdk.jmh:jmh-samples:pom:) jmh-generator-bytecode: jmh-generator-bytecode mvn(org.openjdk.jmh:jmh-generator-bytecode) mvn(org.openjdk.jmh:jmh-generator-bytecode:pom:) jmh: jmh mvn(org.openjdk.jmh:jmh-core) mvn(org.openjdk.jmh:jmh-core:pom:) jmh-core-it: jmh-core-it mvn(org.openjdk.jmh:jmh-core-it) mvn(org.openjdk.jmh:jmh-core-it:pom:) jmh-generator-reflection: jmh-generator-reflection mvn(org.openjdk.jmh:jmh-generator-reflection) mvn(org.openjdk.jmh:jmh-generator-reflection:pom:) jmh-generator-annprocess: jmh-generator-annprocess mvn(org.openjdk.jmh:jmh-generator-annprocess) mvn(org.openjdk.jmh:jmh-generator-annprocess:pom:) jmh-parent: jmh-parent mvn(org.openjdk.jmh:jmh-parent:pom:) jmh-core-benchmarks: jmh-core-benchmarks mvn(org.openjdk.jmh:jmh-core-benchmarks) mvn(org.openjdk.jmh:jmh-core-benchmarks:pom:) Source checksums ---------------- http://hg.openjdk.java.net/code-tools/jmh/archive/65fdc5d5f65d.tar.gz : CHECKSUM(SHA256) this package : b05744d6c35f6988bd4fb8bdf384792bfab406adbc55082c87007f1e1bc07bed CHECKSUM(SHA256) upstream package : b05744d6c35f6988bd4fb8bdf384792bfab406adbc55082c87007f1e1bc07bed This is my second review. Overall good package, I would also consider moving the Maven metadata in jmh-parent into jmh-core (like how jsch-agent-proxy does it) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review