[Bug 1257908] Review Request: perl-Devel-GoFaster - Optimise executable Perl ops

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1257908

Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #1 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Devel-GoFaster-0.000-1.fc24.x86_64.rpm | sort | uniq
-c
      1 libc.so.6()(64bit)
      1 libc.so.6(GLIBC_2.2.5)(64bit)
      1 libperl.so.5.22()(64bit)
      1 perl(:MODULE_COMPAT_5.22.0)
      1 perl(Carp)
      1 perl(Lexical::SealRequireHints) >= 0.007
      1 perl(XSLoader)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
      1 rtld(GNU_HASH)
Binary requires are Ok.

$ rpm -qp --provides perl-Devel-GoFaster-0.000-1.fc24.x86_64.rpm | sort | uniq
-c
      1 perl(Devel::GoFaster) = 0.000
      1 perl-Devel-GoFaster = 0.000-1.fc24
      1 perl-Devel-GoFaster(x86-64) = 0.000-1.fc24
Binary provides are Ok.

rpmlint ./perl-Devel-GoFaster*
perl-Devel-GoFaster.src: W: spelling-error Summary(en_US) Optimise -> Optimist,
Optimism, Optimize
perl-Devel-GoFaster.src: W: spelling-error %description -l en_US optimisations
-> optimizations, optimization, improvisations
perl-Devel-GoFaster.src: W: spelling-error %description -l en_US behaviour ->
behavior
perl-Devel-GoFaster.src: W: spelling-error %description -l en_US optimisation
-> optimization, improvisation, misapplication
perl-Devel-GoFaster.x86_64: W: spelling-error Summary(en_US) Optimise ->
Optimist, Optimism, Optimize
perl-Devel-GoFaster.x86_64: W: spelling-error %description -l en_US
optimisations -> optimizations, optimization, improvisations
perl-Devel-GoFaster.x86_64: W: spelling-error %description -l en_US behaviour
-> behavior
perl-Devel-GoFaster.x86_64: W: spelling-error %description -l en_US
optimisation -> optimization, improvisation, misapplication
perl-Devel-GoFaster.x86_64: E: zero-length
/usr/lib64/perl5/vendor_perl/auto/Devel/GoFaster/GoFaster.bs
2 packages and 1 specfiles checked; 1 errors, 8 warnings.


FIX: Please remove a *.bs file

Otherwise the package looks good.
APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]