https://bugzilla.redhat.com/show_bug.cgi?id=1255370 Nalin Dahyabhai <nalin@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |nalin@xxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |nalin@xxxxxxxxxx --- Comment #1 from Nalin Dahyabhai <nalin@xxxxxxxxxx> --- Taking this one, since it's a build dependency of another one that I'm reviewing. Looks pretty good to me. Here's the checklist from fedora-review, with a few items that I'd like to know more about (search for "[ ]" and "[!]"): Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [X]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. ASL 2.0 is among the Good licenses on Fedora's license list. [X]: License field in the package spec file matches the actual license. No patches are applied, and the bundled license text is that of ASL 2.0, which is in line with the opencontainers charter. [X]: Package must own all directories that it creates. rpmlint complained about /usr/share/gocode{,src{,github.com}}, all of which are owned by "golang". [X]: %build honors applicable compiler flags or justifies otherwise. %build is empty; package exists only to be used when building others. [X]: Package contains no bundled libraries without FPC exception. Package contains no bundled libraries. [ ]: Changelog in prescribed format. It's customary to use a person's full name where the changelog currently lists a Fedora account name. It's not a blocker, but my guess is it's an oversight. [X]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [X]: Development files must be in a -devel package [X]: Package uses nothing in %doc for runtime. [X]: Package consistently uses macros (instead of hard-coded directory names). [X]: Package is named according to the Package Naming Guidelines. Complies with the draft at https://fedoraproject.org/wiki/PackagingDrafts/Go as of this writing. There's no date in the release field, so the Y in 0.Y.gitshortcommit.disttag will need to be manually incremented to keep the sorting order correct. [X]: Package does not generate any conflict. [X]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [-]: Requires correct, justified where necessary. Package has no requirements. [X]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 6 files. [ ]: Package complies to the Packaging Guidelines The package description should be more than just a copy of the summary. Go packaging draft suggests that "noarch" should also be in the ExclusiveArch list. [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. Package requires golang. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [-]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [X]: Final provides and requires are sane (see attachments). [-]: Package functions as described. [!]: Latest version is packaged. [X]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: %check is present and all tests pass. [X]: Packages should try to preserve timestamps of original installed files. [ ]: Spec use %global instead of %define unless justified. Why is copying() not global? [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: golang-github-opencontainers-specs-devel-0-0.1.git0c505a5.fc24.noarch.rpm golang-github-opencontainers-specs-0-0.1.git0c505a5.fc24.src.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Requires -------- golang-github-opencontainers-specs-devel (rpmlib, GLIBC filtered): Provides -------- golang-github-opencontainers-specs-devel: golang(github.com/opencontainers/specs) golang-github-opencontainers-specs-devel Source checksums ---------------- https://github.com/opencontainers/specs/archive/0c505a55d8e9a6427b97adcee02f40c29e621300/specs-0c505a5.tar.gz : CHECKSUM(SHA256) this package : 0aaaacec4e22752dffcfb13f5de234c35b0ffc203db4bb09198a2435c6b69fc0 CHECKSUM(SHA256) upstream package : 0aaaacec4e22752dffcfb13f5de234c35b0ffc203db4bb09198a2435c6b69fc0 Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -n golang-github-opencontainers-specs Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review