https://bugzilla.redhat.com/show_bug.cgi?id=1254778 Kevin Fenzi <kevin@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #4 from Kevin Fenzi <kevin@xxxxxxxxx> --- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: ea88976b9952e80b702b030489f94393 pidgin-2.10.7.tar.bz2 OK - BuildRequires correct OK - Spec handles locales/find_lang OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Doc subpackage needed/used. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Headers/static libs in -devel subpackage. OK - Spec has needed ldconfig in post and postun OK - .pc files in -devel subpackage/requires pkgconfig OK - .so files in -devel subpackage. OK - -devel package Requires: %{name} = %{version}-%{release} OK - .la files are removed. OK - Package is a GUI app and has a .desktop file OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have sane scriptlets. OK - Should have subpackages require base package with fully versioned depend. OK - Should have dist tag OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. rpmlint says: finch.ppc64: W: spelling-error %description -l en_US ncurses -> nurses, curses, n curses finch.x86_64: W: spelling-error %description -l en_US ncurses -> nurses, curses, n curses pidgin.ppc64: W: spelling-error Summary(en_US) multiprotocol -> multiprocessor pidgin.ppc64: W: spelling-error %description -l en_US perl -> Perl, peel, perk finch-devel.ppc64: W: only-non-binary-in-usr-lib finch-devel.ppc64: W: no-documentation finch-devel.x86_64: W: only-non-binary-in-usr-lib finch-devel.x86_64: W: no-documentation pidgin.ppc64: W: non-conffile-in-etc /etc/gconf/schemas/purple.schemas pidgin.ppc64: W: no-manual-page-for-binary gaim pidgin.x86_64: W: spelling-error Summary(en_US) multiprotocol -> multiprocessor pidgin.x86_64: W: spelling-error %description -l en_US perl -> Perl, peel, perk pidgin.x86_64: W: non-conffile-in-etc /etc/gconf/schemas/purple.schemas pidgin.x86_64: W: no-manual-page-for-binary gaim pidgin-devel.ppc64: W: self-obsoletion gaim-devel obsoletes gaim-devel = 2.10.7-25.el7 pidgin-devel.ppc64: W: only-non-binary-in-usr-lib pidgin-devel.ppc64: W: no-documentation pidgin-devel.x86_64: W: self-obsoletion gaim-devel obsoletes gaim-devel = 2.10.7-25.el7 pidgin-devel.x86_64: W: only-non-binary-in-usr-lib pidgin-devel.x86_64: W: no-documentation pidgin-epel.src: W: spelling-error Summary(en_US) multiprotocol -> multiprocessor pidgin-epel.src: W: spelling-error %description -l en_US perl -> Perl, peel, perk All those look ignoreable. pidgin-epel.src:370: W: unversioned-explicit-obsoletes gaim-devel pidgin-epel.src:396: W: unversioned-explicit-obsoletes gaim-meanwhile These should probibly be versioned, or just dropped at this point. pidgin-epel.src:134: W: mixed-use-of-spaces-and-tabs (spaces: line 19, tab: line 134) Could fix if you get a chance. pidgin-epel-debuginfo.ppc64: E: incorrect-fsf-address /usr/src/debug/pidgin-2.10.7/pidgin/getopt.h pidgin-epel-debuginfo.ppc64: E: incorrect-fsf-address /usr/src/debug/pidgin-2.10.7/finch/getopt.h pidgin-epel-debuginfo.ppc64: E: incorrect-fsf-address /usr/src/debug/pidgin-2.10.7/pidgin/gtkdocklet-gtk.c pidgin-epel-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/pidgin-2.10.7/pidgin/getopt.h pidgin-epel-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/pidgin-2.10.7/finch/getopt.h pidgin-epel-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/pidgin-2.10.7/pidgin/gtkdocklet-gtk.c Could let upstream know to update their files. 2. There's a ton of stuff that could be cleaned up in the spec, but I assume you want to keep it close to the Fedora one in order to sync them? If not, you can drop all the rhel4 stuff and all the Fedora stuff thats older than F21. (there's a ton of that cruft. You may want to clean up the fedora spec and sync it to this one) I don't see any blockers, so this package is APPROVED. Do consider cleaning up before import. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review