https://bugzilla.redhat.com/show_bug.cgi?id=725733 --- Comment #6 from Vít Ondruch <vondruch@xxxxxxxxxx> --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #5) > (In reply to Vít Ondruch from comment #3) > > * How to best use the CC. > > Another option would be to stay closer to upstream and use the > > "java -jar" call, but that fails with "Closure::Error: no main manifest > > attribute, in /usr/share/java/closure-compiler/closure-compiler.jar" > > error > > and I was told that this is not supported way how to execute Java stuff > > on Fedora. So any opinion in this matter? > IIUC, specifying the main class in the manifest onlly works if jar is > self-contained > and has all the dependencies, or if the classpath is specified through some > other > means. I'd like something like this, because that could be probably acceptable by upstream (although who knows :)) > > * Best way to require CC. > > - So far, I used BR: closure-compiler but I might change it to > > BR: %{_bindir}/closure-compiler, since that is the executable used > > in the end. > Yeah, for BR either is OK. For R using the path would be annoying because > the file list would have to downloaded. %{_bindir} is always allowed, so I'll go with the R: %{_bindir} > Wouldn't it be easier to use the tarball from github for everything, and > ignore the gem? Hm, I see that the guidelines say that the released gem > *must* be used. Too bad. Don't see any substantial benefits in GH tarballs. They have different issues ... > The only issue seems to be the bundling of Lato and jquery. But that seems > to be completely standard in rubygems. So please just add Provides: > bundled(jquery). At some point we should unbundle jquery from everything, > but most likely it's better to do it in some automated fashion instead of > manually in every package. Well, this is pain :/ I don't think this is worth of the provide, since it would not make sense to fill bugs against every rubygem- package in case there is some issue with the bundled jQuery. Unless you fell you want to escalate this ;) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review