[Bug 1256479] Review Request: gedit-plugin-git - The gedit git plugin

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1256479



--- Comment #4 from Matěj Cepl <mcepl@xxxxxxxxxx> ---
(In reply to Björn "besser82" Esser from comment #3)
> First findings:
> 
> > %description
> > The gedit git plugin packages separately (because it requires
> > packages not available in the RHEL-7 proper but only in EPEL-7)
> 
> The description doesn't tell anything useful about what the package does…

That’s right. It is just a copy from the subpackage of gedit-plugins. I'll try
to do something better. As for the second sentence, see below.

See new src.rpm at
http://mcepl.fedorapeople.org/tmp/gedit-plugin-git-3.14.1-5.el7.src.rpm (SPEC
is also updated)

> > %patch1 -p1 -b .FSF-addr
> 
> Patching copyright headers is discouraged.  See:
> https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address

Of course, the patch is upstream as well.
https://git.gnome.org/browse/gedit-plugins/commit/?id=382a196b177f87c0c1d356a7fa18ec3cefb43d25

> I'm somehow wondering:  Is this package intended for el7, only?  Do we have
> this plugin in Fedora already?

Sorry to be snippy, but if you read that %description which tell you nothing
useful you may understand the situation. ;)

Yes, this is EPEL7 only, and yes it is a part of gedit-plugins in Fedora, but
because it depends on libgit2 which is not in RHEL-7 it has been patched out in
RHEL-7 gedit-plugins package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]