[Bug 1256479] Review Request: gedit-plugin-git - The gedit git plugin

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1256479

Björn "besser82" Esser <bjoern.esser@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bjoern.esser@xxxxxxxxx



--- Comment #3 from Björn "besser82" Esser <bjoern.esser@xxxxxxxxx> ---
First findings:

> %description
> The gedit git plugin packages separately (because it requires
> packages not available in the RHEL-7 proper but only in EPEL-7)

The description doesn't tell anything useful about what the package does…


> %patch1 -p1 -b .FSF-addr

Patching copyright headers is discouraged.  See:
https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address


The URLs you've pasted are not suitable for fedora-review, btw…  Spec resolves
to some HTML-page.  They should look like:

Spec URL:
https://gitlab.com/mcepl/gedit-plugin-git-pkg/raw/epel7/gedit-plugin-git.spec
SRPM URL:
https://mcepl.fedorapeople.org/tmp/gedit-plugin-git-3.14.1-4.el7.src.rpm


I'm somehow wondering:  Is this package intended for el7, only?  Do we have
this plugin in Fedora already?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]