https://bugzilla.redhat.com/show_bug.cgi?id=1229349 --- Comment #5 from Nikos Mavrogiannopoulos <nmavrogi@xxxxxxxxxx> --- (In reply to Christopher Meng from comment #4) > Some issues pointed first: > 1. From what I can understand, it's a library forked from radius-client, > because I saw a very familiar name in beginning of every file ;) Correct. Do you mean Lars Fenneberg? > I don't think you need to install that license breakdown, just put it in > dist-git. These files are not included in main or devel subpkg. No one can > find them from your package. I've put it directly to the spec. It's not so long. > 2. %description devel > Development files for radcli > Better: > %description devel > This package contains libraries and header files for > developing applications that use %{name}. Done > 3. cp %{buildroot}%{_sysconfdir}/%{name}/dictionary > %{buildroot}%{_datadir}/%{name}/dictionary > -> > cp -p Done. > 4. in etc/: > $(INSTALL) -m 600 $(srcdir)/servers $(DESTDIR)$(pkgsysconfdir)/servers" > Is 60 intended to be the proper(best/safest) permission? Yes. > 5. You said you've dropped the port map[1], but I still can see it in tests, > by the way why are tests disabled? The tests which are skipped require a functioning radius server, if that's what you mean. The portmap in tests is a leftover. No need to remove it for the fedora package as it is not installed. > 6. * Mon Jun 15 2015 Nikos Mavrogiannopoulos - 1.2.1-1 > - Initial package > Leave your email there, and drop redundant space. Done. > 7. If you need to autoreconf, then BR autoconf, automake, libtool, otherwise > please drop them. Commented out. > I've seen rpath hack in the spec, since this is your > project, can this be avoided during releasing? Since, this is a Fedora thing it has to got to autotools directly or stay within Fedora. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review