https://bugzilla.redhat.com/show_bug.cgi?id=1229349 --- Comment #4 from Christopher Meng <i@xxxxxxxx> --- I'm having problem with nearby mirrors which can't even update my system now. I will review this when I have access to updates. mock throws updates when I try to review packages everytime. Network I'm using is using CDN cache which causes too many troubles and I'm asking for an examination in few days. Some issues pointed first: 1. From what I can understand, it's a library forked from radius-client, because I saw a very familiar name in beginning of every file ;) I don't think you need to install that license breakdown, just put it in dist-git. These files are not included in main or devel subpkg. No one can find them from your package. Under MIT license: lib/avpair.c, lib/buildreq.c, lib/clientid.c, lib/config.c, lib/dict.c, lib/env.c, lib/ip_util.c, lib/log.c, lib/sendserver.c, lib/util.c, src/local.c, src/radacct.c, src/radexample.c, src/radius.c, src/radlogin.c, src/radstatus.c under BSD license: lib/util.c, src/radiusclient.c, lib/rc-md5.c, lib/tls.c 2. %description devel Development files for radcli Better: %description devel This package contains libraries and header files for developing applications that use %{name}. Also: %description of C code. It was based originally on freeradius-client and is source compatible with it. compatible with it. You don't need to open a newline and put "with it" into that. 3. cp %{buildroot}%{_sysconfdir}/%{name}/dictionary %{buildroot}%{_datadir}/%{name}/dictionary -> cp -p 4. in etc/: $(INSTALL) -m 600 $(srcdir)/servers $(DESTDIR)$(pkgsysconfdir)/servers" Is 60 intended to be the proper(best/safest) permission? 5. You said you've dropped the port map[1], but I still can see it in tests, by the way why are tests disabled? 6. * Mon Jun 15 2015 Nikos Mavrogiannopoulos - 1.2.1-1 - Initial package Leave your email there, and drop redundant space. 7. If you need to autoreconf, then BR autoconf, automake, libtool, otherwise please drop them. I've seen rpath hack in the spec, since this is your project, can this be avoided during releasing? [1]---https://github.com/radcli/radcli/commit/64a26f116b7e2197c7a92e329c93f288adfed0c4 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review