[Bug 1150566] Review Request: wcm - Wal Commander

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1150566

Vladimir Stackov <amigo.elite@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|amigo.elite@xxxxxxxxx       |



--- Comment #14 from Eugene A. Pivnev <ti.eugene@xxxxxxxxx> ---
(In reply to William Moreno from comment #13)
>       Orphan dir: /usr/share/icons/hicolor/*/apps
>       Add Requires: hicolors-icon-theme

Fixed

> Fail: gtk-update-icon-cache is invoked in %postun and %posttrans.

Fixed

> Fail: Sources can be downloaded from URI in Source: tag

Fixed

> Fail: Package contains BR: python2-devel or python3-devel

Fixed (python scripts removed from installation - these are devel tools)

> Fail: Permissions on files are set properly.
>       E: non-executable-script /usr/share/wcm/styles/solarize.sh 644
> /bin/bash
>       E: non-executable-script /usr/share/wcm/styles/solarized-gen.py 644
> /usr/bin/python

Fixed (devel tools)

> Fail: Patches link to upstream bugs/comments/lists

Fixed

> Note: W: name-repeated-in-summary C WCM
>       Drop the mane of the package in summary

?
"WCM Commander" is original application name.
But developers recomended to use "wcm" as short name.

> Note: W: no-manual-page-for-binary wcm

Fixed

> Note: W: file-not-utf8 /usr/share/doc/wcm/CHANGELOG.txt

Fixed

So:

SPEC: https://tieugene.fedorapeople.org/rpms/wcm/wcm.spec
SRPM: https://tieugene.fedorapeople.org/rpms/wcm/wcm-0.20.0-4.fc21.src.rpm
Koji:
EL7: https://koji.fedoraproject.org/koji/taskinfo?taskID=10731456
F23: https://koji.fedoraproject.org/koji/taskinfo?taskID=10731472

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]