https://bugzilla.redhat.com/show_bug.cgi?id=1150566 --- Comment #13 from William Moreno <williamjmorenor@xxxxxxxxx> --- Package Review ============== Need Work: ========== Fail: Package requires other packages for directories it uses. Fail: Package must own all directories that it creates. Orphan dir: /usr/share/icons/hicolor/*/apps Add Requires: hicolors-icon-theme Fail: gtk-update-icon-cache is invoked in %postun and %posttrans. See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache Fail: Sources can be downloaded from URI in Source: tag Fail: SourceX tarball generation or download is documented. W: invalid-url Source0: https://github.com/corporateshark/WalCommander/archive/WCMCommander-release-0.20.0.tar.gz HTTP Error 404: Not Found The link: https://github.com/corporateshark/WCMCommander/archive/release-0.20.0.tar.gz Work for me, please check if work for you and update it in the spec Fail: Package contains BR: python2-devel or python3-devel There is some Python code in the tarball, please verify I will recomend include BuildRequires: python3-devel Fail: Permissions on files are set properly. E: non-executable-script /usr/share/wcm/styles/solarize.sh 644 /bin/bash E: non-executable-script /usr/share/wcm/styles/solarized-gen.py 644 /usr/bin/python This files do not look to need execusion permissions, try removing the shebang or set then to 755 Fail: Patches link to upstream bugs/comments/lists or are otherwise justified. If you can propose some patches upstream please do it, if patches are Fedora specific please add a comment about it in the spec. Note: W: name-repeated-in-summary C WCM Drop the mane of the package in summary Note: W: no-manual-page-for-binary wcm This is a easy fix, yua can use the package manedit to create a Unix manapage and include it, even a minimal man page can improve the user experience please propose the man page upstrea, Note: W: file-not-utf8 /usr/share/doc/wcm/CHANGELOG.txt See: https://fedoraproject.org/wiki/Packaging_tricks#Convert_encoding_to_UTF-8 Please fix these issues to check: ?: Package complies to the Packaging Guidelines ===== MUST items ===== C/C++: Pass: Package does not contain kernel modules. Pass: Package contains no static executables. Pass: Package does not contain any libtool archives (.la) Pass: Rpath absent or only used for internal libs. Generic: Pass: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. Pass: License field in the package spec file matches the actual license. Pass: %build honors applicable compiler flags or justifies otherwise. Pass: Package contains no bundled libraries without FPC exception. Pass: Changelog in prescribed format. Pass: Sources contain only permissible code or content. NA : Development files must be in a -devel package Pass: Package uses nothing in %doc for runtime. Pass: Package consistently uses macros (instead of hard-coded directory names). Pass: Package is named according to the Package Naming Guidelines. Pass: Package does not generate any conflict. Pass: Package obeys FHS, except libexecdir and /usr/target. NA : If the package is a rename of another package, proper Obsoletes and Provides are present. Pass: Requires correct, justified where necessary. Pass: Spec file is legible and written in American English. NA : Package contains systemd file(s) if in need. Pass: Useful -debuginfo package or justification otherwise. Pass: Package is not known to require an ExcludeArch tag. ARM: http://arm.koji.fedoraproject.org/koji/taskinfo?taskID=3122269 s390: http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=1936707 ppc: http://ppc.koji.fedoraproject.org/koji/taskinfo?taskID=2705219 Pass: Large documentation must go in a -doc subpackage. Pass: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Pass: Package installs properly. Pass: Rpmlint is run on all rpms the build produces. Pass: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Pass: Package does not own files or directories owned by other packages. Pass: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Pass: Package uses either %{buildroot} or $RPM_BUILD_ROOT Pass: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Pass: Macros in Summary, %description expandable at SRPM build time. Pass: Package contains desktop file if it is a GUI application. Pass: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. Pass: Dist tag is present. Pass: Package does not contain duplicates in %files. Pass: Package use %makeinstall only when make install DESTDIR=... doesn't work. Pass: Package is named using only allowed ASCII characters. Pass: Package does not use a name that already exists. Pass: Package is not relocatable. Pass: Sources used to build the package match the upstream source, as provided in the spec URL. 83fc7d79f3a17623674adb7e0d7c9fb9 release-0.20.0.tar.gz 83fc7d79f3a17623674adb7e0d7c9fb9 WCMCommander-release-0.20.0.tar.gz Pass: Spec file name must match the spec package %{name}, in the format %{name}.spec. Pass: File names are valid UTF-8. Pass: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: NA: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. Pass: Final provides and requires are sane (see attachments). Pass: Package functions as described. Pass: Latest version is packaged. Pass: Package does not include license text files separate from upstream. NA: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. Pass: Package should compile and build into binary rpms on all supported architectures. NA: %check is present and all tests pass. Pass: Packages should try to preserve timestamps of original installed files. Pass: Packager, Vendor, PreReq, Copyright tags should not be in spec file Pass: Reviewer should test that the package builds in mock. Pass: Buildroot is not present Pass: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Pass: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. Pass: Uses parallel make %{?_smp_mflags} macro. Pass: SourceX is a working URL. Pass: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: Pass: Rpmlint is run on debuginfo package(s). Pass: Rpmlint is run on all installed packages. Pass: Large data in /usr/share should live in a noarch subpackage if package is arched. Pass: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: wcm-0.20.0-3.fc21.x86_64.rpm wcm-0.20.0-3.fc21.src.rpm wcm.x86_64: W: name-repeated-in-summary C WCM wcm.x86_64: W: file-not-utf8 /usr/share/doc/wcm/CHANGELOG.txt wcm.x86_64: E: non-executable-script /usr/share/wcm/styles/solarize.sh 644 /bin/bash wcm.x86_64: E: non-executable-script /usr/share/wcm/styles/solarized-gen.py 644 /usr/bin/python wcm.x86_64: W: no-manual-page-for-binary wcm wcm.src: W: name-repeated-in-summary C WCM wcm.src: W: invalid-url Source0: https://github.com/corporateshark/WalCommander/archive/WCMCommander-release-0.20.0.tar.gz HTTP Error 404: Not Found 2 packages and 0 specfiles checked; 2 errors, 5 warnings. Rpmlint (debuginfo) ------------------- Checking: wcm-debuginfo-0.20.0-3.fc21.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- wcm.x86_64: W: name-repeated-in-summary C WCM wcm.x86_64: W: file-not-utf8 /usr/share/doc/wcm/CHANGELOG.txt wcm.x86_64: E: non-executable-script /usr/share/wcm/styles/solarize.sh 644 /bin/bash wcm.x86_64: E: non-executable-script /usr/share/wcm/styles/solarized-gen.py 644 /usr/bin/python wcm.x86_64: W: no-manual-page-for-binary wcm 2 packages and 0 specfiles checked; 2 errors, 3 warnings. Requires -------- wcm (rpmlib, GLIBC filtered): /bin/sh libX11.so.6()(64bit) libc.so.6()(64bit) libfreetype.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libsmbclient.so.0()(64bit) libsmbclient.so.0(SMBCLIENT_0.1.0)(64bit) libssh2.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libutf8proc.so.0.1()(64bit) rtld(GNU_HASH) Provides -------- wcm: appdata() appdata(wcm.appdata.xml) application() application(wcm.desktop) wcm wcm(x86-64) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review