https://bugzilla.redhat.com/show_bug.cgi?id=1243379 --- Comment #3 from František Dvořák <valtri@xxxxxxxxxx> --- Great, good work. :-) More issues (not noticed before or in the new changes): 10) linking - I would rather not include the main.o file in the library (I guess the 'main' symbol will be problematic) - also there is missing -ltinyxml: it will add the automatic dependency on the tinyxml library and fix undefined-non-weak-symbol errors from rpmlint Something like?: g++ $RPM_OPT_FLAGS -shared -o lib%{name}.so.0.1 \ -Wl,-soname,lib%{name}.so.0.1 `ls *.o | grep -v main.o` -ltinyxml 11) why is ./tinyxpath called twice in the %check? It works OK though. 12) installing AUTHORS manually is not needed, %doc macro in %file will pick it automatically (or in case of manual installation it would be better _pkgdocdir macro) See: http://fedoraproject.org/wiki/Packaging:Guidelines#Documentation 13) devel subpackage could have also runtime require on tinyxml-devel package ...because tinyxpath headers includes headers from tinyxml. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review