https://bugzilla.redhat.com/show_bug.cgi?id=1243379 --- Comment #2 from nobrakal@xxxxxxxxx --- Spec URL: https://nobrakal.fedorapeople.org/tinyxpath.spec SRPM URL: https://nobrakal.fedorapeople.org/tinyxpath-1.3.1-2.fc22.src.rpm Hi, Thank you for your reply :D (and yes, tinyxml is my pet peeve) So, >1) License file > >The proper way is to ask upstream to include the license text: > >https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text Reported: https://sourceforge.net/p/tinyxpath/feature-requests/3/ 2) Done >3) shared library versioning > >See the link: http://fedoraproject.org/wiki/Packaging:Guidelines#Downstream_.so_name_versioning > >The soname should be something like libxpath.so.0.1. Done, I use "1" instead of %{version} on the contrary of the doc... Because %{version} is very long (1.3.1) >4) Done >5) > >The problem is there is one error. It is probably not important error, but it >could be reported upstream (and ignored in the %check). Corrected with a patch, seems like a bug, reported https://sourceforge.net/p/tinyxpath/support-requests/7/ 6) Corrected 7) Corrected 8) Corrected, I've removed the out-of-date "rm -rf $RPM_BUILD_ROOT" 9) Corrected, you're right ;) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review