Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: asl - Macro Assembler AS https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240807 ------- Additional Comments From lxtnow@xxxxxxxxx 2007-06-01 22:55 EST ------- well, ----------- Spec file: ----------- your spec file doesn't follow packaging guidelines and SHOULD be fix. * release tag : isn't good. as it's your first build for this package the release MUST be set to 0.1 (as it's provided with build version release). So, the release should be 0.1.build55 instead of 0.8.bld55. * Source tag : the source path should be point to externel downloadable link or comment why you can't paste the full location in spec file. * Buildroot tag : should be review, see packaging guidelines page. * %build stage : mock's working...comment is coming soon. About "make test" command: it's SHOULD be paste in %check stage juste add it after %build stage. * %clean stage is missing, SHOULD be fix. * %files stage : this section can be improved. the use of %dir /path/to/folder is not needed to own package. So your %files section will looks like this: %files %defattr(-,root,root) %doc COPYING README* TODO BENCHES changelog %doc doc/* %{_bindir}/* %{_datadir}/asl %{_datadir]/asl/include %{_datadir}/asl/lib %{_mandir}/man1/*.gz * note that I added changelog file which was missing. * also note the use of macros instead of hardcoded path (which's not apropriate) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review