https://bugzilla.redhat.com/show_bug.cgi?id=1234664 Brian Demers <brdemers@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brdemers@xxxxxxxxx --- Comment #1 from Brian Demers <brdemers@xxxxxxxxx> --- Informal review: https://fedorahosted.org/released/javapackages/doc/ This section, isn't guaranteed to work: ``` # overwrite bundled libs with symlinks to system libraries ln -sfn /usr/share/java/xmlgraphics-commons.jar jchart2d/ext/xmlgraphics-commons-1.3.1.jar ln -sfn /usr/share/java/jide-oss.jar jchart2d/ext/jide-oss-2.9.7.jar ln -sfn /usr/share/java/proguard/proguard.jar jchart2d/ext/build/proguard-4.5.1.jar ln -sfn /usr/share/java/junit.jar jchart2d/ext/build/junit-4.8.1.jar ``` Something should probably be done in %build and these libs removed in %prep http://fedoraproject.org/wiki/Packaging:Java#BuildRequires_and_Requires I understand the need to override the jars, as that is a fedora requirement, but your BuildDepends could be any version, which could cause problems depending on which version is installed. Run fedora-review locally to see other errors: `dnf install -y fedora-review fedora-review-plugin-java` `fedora-review -b 1234664` You will see errors and warnings such as: Rpmlint ------- Checking: jchart2d-3.2.2-1.fc23.noarch.rpm jchart2d-javadoc-3.2.2-1.fc23.noarch.rpm jchart2d-3.2.2-1.fc23.src.rpm jchart2d.noarch: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory # i'm not sure why this python call is here ? jchart2d.noarch: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 1 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review