https://bugzilla.redhat.com/show_bug.cgi?id=1243550 Brian Demers <brdemers@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brdemers@xxxxxxxxx --- Comment #1 from Brian Demers <brdemers@xxxxxxxxx> --- Informal Review: Guessing this should be added to RDO: https://openstack.redhat.com/packaging/rdo-packaging.html#_how_to_add_a_new_package_to_rdo_master_packaging Take a look at: https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Release_Tag for versioning and dist tag See https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL to set Source0 to a URL (or a comment) Requires and BuildRequires are fragmented, which makes the spec harder to read. Not sure where the 'ceilometer' group is created, but you might want to make a note about, I'm assuming it gets created by another openstack rpm, but i'm not sure. https://fedoraproject.org/wiki/Packaging:UsersAndGroups %license is missing Download and run 'fedora-review -b 1243550' you will see other errors and messages that will need to be cleaned up. https://fedoraproject.org/wiki/Package_Review_Process -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review