Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mrxvt - Multi-tabbed terminal emulator. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223422 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-05-31 12:14 EST ------- Well, much improvement!! However, still some points to be fixed. * %changelog - Please use changelog properly. i.e. If you change/modify spec file/srpm, write a brief summary in %changelog (see specs of other packages for example) - And please increment release number when you modify spec file with version unchanged. * sourceURL - For Source0, please refer to http://fedoraproject.org/wiki/Packaging/SourceURL * Unused definition - Please remove unused definition. It doesn't seem that %x11_app_defaults_dir is used anywhere. * Parallel make - Please support parallel make when possible (please check the section "Parallel make" of http://fedoraproject.org/wiki/Packaging/Guidelines * attr - Usually, %attr(755,root,root) for binary should not be needed when installation is done properly. * Directory ownership - Please own directories which are created by this package and are not owned by other packages. For example, this package should own directory %{_sysconfdir}/%{name} * Macros - Please use macros. %{_sysconfdir} for /etc, for example. * noreplace for config files - For config files, please use %config(noreplace) * documentatin directory - Documentations should be under %{_datadir}/doc/%{name}-%{version}. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review