[Bug 1241919] Review Request: python-line_profiler - Line-by-line profiler for Python.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1241919



--- Comment #15 from Orion Poplawski <orion@xxxxxxxxxxxxx> ---
(In reply to Matthias Runge from comment #14)
> more comments:
> 
> - drop python2 related macros, afaik they are not required, even on rhel6.

They are still needed on rhel6.

> - I would name the package python-line-profiler:
> https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Separators

NO - the _ is fine if it's part of the name, as it is.  Read the whole section.

> - you shouldn't need %attr at all

Apparently the .so gets installed with 775 (see comment #5)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]