[Bug 1241919] Review Request: python-line_profiler - Line-by-line profiler for Python.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1241919



--- Comment #14 from Matthias Runge <mrunge@xxxxxxxxxx> ---
more comments:

- drop python2 related macros, afaik they are not required, even on rhel6.
- an example for a more renovated py2/py3 building is here:
https://fedoraproject.org/wiki/Packaging:Python#Example_spec_file
- your package needs to provide python2-line_profiler and python3-line_profiler
- I would name the package python-line-profiler:
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Separators
- drop requires on python2, python3 and python-libs
-second sed foo in %prep is not useful (it's already deleted by the first one)
- be more specific on file list (other than just including everything)
- you shouldn't need %attr at all
- please take care to use compiler flags in build

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]