https://bugzilla.redhat.com/show_bug.cgi?id=1224265 --- Comment #12 from Jan Staněk <jstanek@xxxxxxxxxx> --- I have uploaded updated SPEC and SRPM, links are still the same. > * You can use -print and -delete as the options for find > to log and remove the disallowed files: > - find %{buildroot}%{python3_sitelib} -name '*.exe' | xargs rm -f > + find %{buildroot} -name '*.exe' -print -delete > With that, you need also only one line to find in both py2 and py3 folders. > You should do that removal early in %prep, but I do not know if install fails. > https://fedoraproject.org/wiki/Packaging:Guidelines#No_inclusion_of_pre-built_binaries_or_libraries I changed the find commands to use the -delete switch. However, they cannot be moved into %prep section, as their purpose is to remove any *.exe files generated during build, if any. > [!]: Package must own all directories that it creates. > Note: Directories without known owners: /etc/polkit-1/rules.d, /etc/polkit-1 > => This is handled in PolicyKit. So you must add Requires: polkit Require for polkit added. > [!]: Package does not own files or directories owned by other packages. > => Please remove them from %files, hicolor-icon-theme takes care of that. > => Add Requires: hicolor-icon-theme Require for hicolor-icon-theme added, and the %files line was changed to only match the concrete files (no directories). > [!]: gtk-update-icon-cache is invoked in %postun and %posttrans if package > contains icons. > Note: icons in udiskie The icon cache scriptlet was already there, just beyond the %check section. To be sure, I moved it before that section. > => List manpage without %doc, it is a separate file and has nothing to do with documentation folder. %doc before manpages removed. > [!]: Fully versioned dependency in subpackages if applicable. > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python-udiskie , python3-udiskie This package works "backwards" in this case - the main package requires one of the subpackages and not the other way around. To these requires, I added the %{version}-%{release} macros (no %{?_isa}, as they are all noarch). > [!]: Package functions as described. > => several open issues that currently prevent fully functionality. I'm not sure which issues you are refering to. If you mean the github ones, they are mainly RFE or authors's own plans for the future. > [!]: Packages should try to preserve timestamps of original installed > files. > => Use 'install -p' or 'cp -p' instead. Went through the used commands and add the -p switch when applicable. I hope I did not miss any issue, if so, please point me to it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review