https://bugzilla.redhat.com/show_bug.cgi?id=1234649 --- Comment #5 from Mike Ruckman <mruckman@xxxxxxxxxx> --- (In reply to Michael Schwendt (Fedora Packager Sponsors Group) from comment #4) > > # sitelib for noarch packages, sitearch for others (remove the unneeded one) > > > BuildArch: noarch > > Notice the hint in brackets. > Fixed. > > > Requires: libvirt > > Requires: libguestfs > > Requires: libguestfs-tools > > Requires: python-requests > > Explicit Requires benefit from a comment that explains the dependency. > Without such comments, packagers sometimes remove dependencies accidentally. > Added comments for each of the requires. > > > %dir %{_sysconfdir}/testcloud > > %dir %attr(777, root, root) %{_sharedstatedir}/testcloud/cache > > %dir %attr(777, root, root) %{_sharedstatedir}/testcloud/instances > > > > %{_sysconfdir}/testcloud/settings.p* > > Directory %{_sharedstatedir}/testcloud/ is not included yet: > https://fedoraproject.org/wiki/Packaging: > Guidelines#File_and_Directory_Ownership > Thanks for catching this. I didn't know I needed to be that explicit, I thought claiming the other dirs was enough. > What is the reason to make the directories *world-writable*? The README > doesn't give a rationale either, but just says "any permitted user" which is > anyone for a world-writable dir. > > https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions > This one I'm not sure how to figure out. Getting permissions ironed out for this has been a pain so far - so I welcome any ideas :) As for the world-writeable permissions I was using, it allowed anyone to run the tool and download images to those directories. I've tested a couple other permissions sets and haven't found something that works. What's the best way to solve this? The user fires off a command that downloads the image (as that user), then virsh and friends take over, which need to be able to manipulate that directory. Would giving permissions to the qemu group be a better fit? > > > %{_sysconfdir}/testcloud/settings.p* > > Its default contents refer to /var/lib/testCloud/ with a different and > misleading uppercase 'C' in the spelling. > Thanks, thought I'd caught all the capitals (the old name was testCloud - but decided to change it before release). > > > /usr/bin/testcloud > > %{python_sitelib}/testcloud/init.py > > Both define version 0.0.1 while the package claims it is 0.1.0. Again, thought I'd caught everything that needed updating in the code. It's fixed now, thanks! Once I get the permissions ironed out I'll update the srpm and spec file online for you to take a look at. Thanks again! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review