https://bugzilla.redhat.com/show_bug.cgi?id=1234649 --- Comment #4 from Michael Schwendt (Fedora Packager Sponsors Group) <bugs.micheal@xxxxxxx> --- > # sitelib for noarch packages, sitearch for others (remove the unneeded one) > BuildArch: noarch Notice the hint in brackets. > Requires: libvirt > Requires: libguestfs > Requires: libguestfs-tools > Requires: python-requests Explicit Requires benefit from a comment that explains the dependency. Without such comments, packagers sometimes remove dependencies accidentally. > %dir %{_sysconfdir}/testcloud > %dir %attr(777, root, root) %{_sharedstatedir}/testcloud/cache > %dir %attr(777, root, root) %{_sharedstatedir}/testcloud/instances > > %{_sysconfdir}/testcloud/settings.p* Directory %{_sharedstatedir}/testcloud/ is not included yet: https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership What is the reason to make the directories *world-writable*? The README doesn't give a rationale either, but just says "any permitted user" which is anyone for a world-writable dir. https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions > %{_sysconfdir}/testcloud/settings.p* Its default contents refer to /var/lib/testCloud/ with a different and misleading uppercase 'C' in the spelling. > /usr/bin/testcloud > %{python_sitelib}/testcloud/init.py Both define version 0.0.1 while the package claims it is 0.1.0. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review