https://bugzilla.redhat.com/show_bug.cgi?id=1227061 --- Comment #2 from Michele Baldessari <michele@xxxxxxxxxx> --- Hi Zbigniew, (In reply to Zbigniew Jędrzejewski-Szmek from comment #1) > - BuildRoot and defattr can be removed [1] (unless you're packaging for > EPEL5 too). Done as EPEL5 is out of scope. > - This is a preference thing, but the guidelines say that macros should be > used *for directories* [2]. There's no specification to use e.g. > %{__install} instead of install. I personally think that this makes reading > the spec file much harder for not gain. Ok, I have changed this. I am running "install" instead of /usr/bin/install and am assuming that the PATH will be set correctly in the buildroots. > - Note for the future: bash completion file should go in > %{_datadir}/bash-completion/completions/, not in /etc/bash_completions.d. > The latter is a legacy location. Thanks, I have added a comment in the spec file for future reference > Requires > -------- > pcp2pdf (rpmlib, GLIBC filtered): > /usr/bin/python > /usr/bin/python3 > config(pcp2pdf) > > The dependency on python looks wrong. Maybe there's a file header with > #!/usr/bin/python somewhere? Indeed there was a spurious line, which I removed. > pcp2pdf.noarch: E: description-line-too-long C Utility to creates PDF > reports from Performance Co-Pilot archives. It allows to choose > > Also "s" in "creates" is unnecessary. > > [1] https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag > [2] https://fedoraproject.org/wiki/Packaging:Guidelines#Macros Fixed. Spec URL: http://acksyn.org/files/rpms/pcp2pdf/pcp2pdf.spec SRPM URL: http://acksyn.org/files/rpms/pcp2pdf/pcp2pdf-0.3-2.fc22.src.rpm Thanks again, Michele -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review