https://bugzilla.redhat.com/show_bug.cgi?id=1227022 --- Comment #2 from Michele Baldessari <michele@xxxxxxxxxx> --- Hi Zbigniew, (In reply to Zbigniew Jędrzejewski-Szmek from comment #1) > - %defattr is not needed Done > - I'd suggest adding %global _docdir_fmt %{name} to share license and doc > dirs between subpackages Makes sense, done > - Afaics, the source is python 2/3 compatible, and 2to3 is not used. This > means that most likely everything can be built from the same directory. So > the whole thing with %{py3dir} can be removed. I have done this as well. I have tested both packages and they work okay. Spec URL: http://acksyn.org/files/rpms/python-jellyfish/python-jellyfish.spec SRPM URL: http://acksyn.org/files/rpms/python-jellyfish/python-jellyfish-0.5.0-2.fc22.src.rpm Thanks for the review, much appreciated. Michele -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review