https://bugzilla.redhat.com/show_bug.cgi?id=1226557 --- Comment #1 from Michael Schwendt (Fedora Packager Sponsors Group) <bugs.micheal@xxxxxxx> --- > amsynth.x86_64: E: invalid-appdata-file /usr/share/appdata/amsynth.appdata.xml "rpmlint -i …" is more verbose. The background is that rpmlint runs "appdata-validate" on the file, not "appstream-util validate-relax". A brief look at the package. Build output says: checking for ALSA... no but OSS? checking for LASH... no checking for SNDFILE... no checking for DSSI... no | | Build with OSS support................................ : yes | Build with ALSA support............................... : no | Build with JACK support............................... : yes | Build with JACK MIDI support.......................... : yes | Build with JACK session support....................... : yes | Build with LASH support............................... : no | Build DSSI plugin..................................... : no | Build LV2 plugin...................................... : yes | | Use libsndfile for .wav output support................ : no What's the reason why these are not enabled? > %package lv2-plugin As this plugin (based on the LV2 Plugin Standard) is an add-on to 'lv2' (sort of a mother package), I would expect the subpackage name to be different and follow Fedora's %{parent}-%{child} naming guidelines: lv2-amsynth (or lv2-amsynth-plugin if to be explicit that it's a plugin) https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.28General.29 # dnf list lv2\*|wc -l 40 The rationale is that the plugin doesn't extend "amsynth" itself but any other program capable of loading LV2 based plugins. The subpackage also needs to depend on a provider of %{_libdir}/lv2/ because it stores files in there. Package "lv2" includes that dir. > License: GPLv2 Please run "fedora-review -b 1226557" on this ticket. Several amsynth source files I've checked briefly claim the licensing is "GPLv2+" because of the "or later" clause. > %doc COPYING AUTHORS README https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text > %{_datadir}/appdata/%{name}.metainfo.xml This is included in the wrong package. It's for the LV2 plugin. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review