https://bugzilla.redhat.com/show_bug.cgi?id=1079064 --- Comment #17 from Jason Tibbitts <tibbs@xxxxxxxxxxx> --- So, this has already gone through a bunch of review and the spec is about as clean as they come. There are a couple of tiny rpmlint issues, which aren't blockers: btbuilder.x86_64: W: no-manual-page-for-binary btbuilder Would be nice if there was a manpage, but it's not essential. btbuilder-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/btbuilder-0.5.2/src/SDL_mng.c btbuilder-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/btbuilder-0.5.2/src/SDL_mng.h These have old copies of the GPL header which have the wrong address for the FSF. Not a huge deal, but upstream should probably fix it. However, that does unconver another issue: The files SDL_mng.c and SDL_mng.h appear to come from somewhere else and have a different license. Do you know where they're from? I can't find them on the Debian code search site so they may not be bundled from another project, but I would like to make sure. In the same vein, what about the code in "util"? It appears to be very old, and has no license. At least compressor.* and file.* are also present in the source tree, though file.C has several significant changes. Neither are particularly large and appear to, well, not really be much in the way of code anyway. Still, we have to be precise about these things. And, finally, uh, when I run it things are pretty weird. I get this absolutely, hilariously massive window which I cannot resize. A screenshot of my desktop would be really big and have all sorts of embarrassing crap on it, but here's xwininfo output: xwininfo: Window id: 0x4400003 (has no name) Absolute upper-left X: 698 Absolute upper-left Y: 174 Relative upper-left X: 0 Relative upper-left Y: 0 Width: 3200 Height: 2000 Depth: 24 Visual: 0x21 Visual Class: DirectColor Border width: 0 Class: InputOutput Colormap: 0x440000c (not installed) Bit Gravity State: ForgetGravity Window Gravity State: NorthWestGravity Backing Store State: NotUseful Save Under State: no Map State: IsViewable Override Redirect State: no Corners: +698+174 --58+174 --58-226 +698-226 -geometry 3200x2000--58+153 3200 x 2000? My desktop is large, but not rectangular. Three 24" 16x10 monitors, one above and one to the left of center. So I can't see a quarter of the window as it is off in the region where I have no monitor. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review