[Bug 1196827] Review Request: postbooks - PostgreSQL-based accounting and ERP suite, Qt-based desktop version

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1196827



--- Comment #7 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
Issues:

This package should have an appdata file [1]. It's not mandatory, just strongly
encouraged, but I think it would be really nice for postbooks to show up
prominently in gnome software.

[1] https://fedoraproject.org/wiki/Packaging:AppData

postbooks-libs hath no license.

The same as in other packages:
- xpm is deprecated and the icon is awfully small.
- /usr/share/applications/postbooks.desktop: warning: key "Encoding" in group
"Desktop Entry" is deprecated

Apart from that, things seem mostly kosher.

rpmlint:
postbooks.src: W: spelling-error Summary(en_US) xTuple -> sextuplet
postbooks.src: W: summary-not-capitalized C xTuple Accounting/ERP suite desktop
client
postbooks.src: W: spelling-error %description -l en_US xTuple -> sextuplet
postbooks.src:77: W: macro-in-comment %{buildroot}
postbooks.src:78: W: macro-in-comment %{buildroot}
postbooks.src:78: W: macro-in-comment %{_libdir}
postbooks.src: W: invalid-url Source0:
https://github.com/xtuple/qt-client/archive/v4.8.2.tar.gz HTTP Error 404: Not
Found
1 packages and 0 specfiles checked; 0 errors, 7 warnings.

postbooks.x86_64: W: spelling-error Summary(en_US) xTuple -> sextuplet
postbooks.x86_64: W: summary-not-capitalized C xTuple Accounting/ERP suite
desktop client
postbooks.x86_64: W: spelling-error %description -l en_US xTuple -> sextuplet
postbooks.x86_64: W: incoherent-version-in-changelog 4.8.1-1 ['4.8.2-1.fc22',
'4.8.2-1']
postbooks.x86_64: W: no-documentation
postbooks.x86_64: W: no-manual-page-for-binary xtuple
postbooks.x86_64: W: no-manual-page-for-binary postbooks
postbooks-libs.x86_64: W: spelling-error %description -l en_US xTuple ->
sextuplet
postbooks-libs.x86_64: W: spelling-error %description -l en_US libpostbooks ->
pocketbooks
postbooks-libs.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libxtuplecommon.so.1.0.0 /lib64/libQtXmlPatterns.so.4
postbooks-libs.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libxtuplecommon.so.1.0.0 /lib64/libpthread.so.0
postbooks-libs.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libxtuplecommon.so.1.0.0 /lib64/libm.so.6
postbooks-libs.x86_64: W: no-documentation

All ignorable.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]