https://bugzilla.redhat.com/show_bug.cgi?id=1196782 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #7 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- Package looks good. Some similar comments apply as in the other package: - xpm icons are deprecated. It's better to use png or even vector graphics. Please use at least 128x128 pixel bitmap in the desktop file. - I think Summary should be changed to say "postbooks", because the user cares more about the product than the author, but it's your call of course. Package is APPROVED. Rpmlint ------- Checking: xtuple-csvimp-0.5.1-1.fc23.x86_64.rpm xtuple-csvimp-devel-0.5.1-1.fc23.x86_64.rpm xtuple-csvimp-0.5.1-1.fc23.src.rpm xtuple-csvimp.x86_64: W: summary-not-capitalized C xTuple data import utility xtuple-csvimp.x86_64: W: incoherent-version-in-changelog 0.5.0-1 ['0.5.1-1.fc23', '0.5.1-1'] Typo? xtuple-csvimp.x86_64: W: no-documentation xtuple-csvimp.x86_64: W: no-manual-page-for-binary csvimp xtuple-csvimp-devel.x86_64: W: no-documentation xtuple-csvimp.src: W: summary-not-capitalized C xTuple data import utility xtuple-csvimp.src:44: W: macro-in-comment %{buildroot} xtuple-csvimp.src:45: W: macro-in-comment %{buildroot} xtuple-csvimp.src:45: W: macro-in-comment %{_libdir} xtuple-csvimp.src: W: file-size-mismatch v0.5.1.tar.gz = 501760, https://github.com/xtuple/csvimp/archive/v0.5.1.tar.gz = 217047 3 packages and 0 specfiles checked; 0 errors, 10 warnings. Requires -------- xtuple-csvimp-devel (rpmlib, GLIBC filtered): libdmtx-devel qt-devel xtuple-openrpt-devel xtuple-csvimp (rpmlib, GLIBC filtered): libMetaSQL.so.1()(64bit) libQtCore.so.4()(64bit) libQtGui.so.4()(64bit) libQtNetwork.so.4()(64bit) libQtSql.so.4()(64bit) libQtXml.so.4()(64bit) libQtXmlPatterns.so.4()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libopenrptcommon.so.1()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) Provides -------- xtuple-csvimp-devel: xtuple-csvimp-devel xtuple-csvimp-devel(x86-64) xtuple-csvimp: application() application(csvimp.desktop) libcsvimpplugin.so()(64bit) xtuple-csvimp xtuple-csvimp(x86-64) Unversioned so-files -------------------- xtuple-csvimp: /usr/lib64/csvimp/plugins/libcsvimpplugin.so OK for plugins. Source checksums ---------------- https://github.com/xtuple/csvimp/archive/v0.5.1.tar.gz : CHECKSUM(SHA256) this package : e2de4dbddabddcdccf712e9ac092bcacda1cebf31c6dd7ea17e55908711d0005 CHECKSUM(SHA256) upstream package : a13289fc0c43bbb53aa49d40acfc2a843c73b643c5b3339717db7e274afac17a diff -r also reports differences Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04 Command line :/usr/bin/fedora-review -b 1196782 -o-n Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review