https://bugzilla.redhat.com/show_bug.cgi?id=1218277 gil cattaneo <puntogil@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #7 from gil cattaneo <puntogil@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. Note: Cannot find LICENSE.md in rpm(s) See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text IGNORE ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "BSD (2 clause)", "Apache (v2.0)", "Unknown or generated". 722 files have unknown license. Detailed output of licensecheck in /home/gil/1218277-mongo-tools/review-mongo- tools/licensecheck.txt [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/licenses [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/licenses [x]: %build honors applicable compiler flags or justifies otherwise. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: Using prebuilt rpms. [-]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [?]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [?]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [?]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: mongo-tools-3.0.3-1.fc23.i386.rpm mongo-tools-3.0.3-1.fc23.src.rpm mongo-tools.src:13: W: mixed-use-of-spaces-and-tabs (spaces: line 13, tab: line 4) 2 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Requires -------- mongo-tools (rpmlib, GLIBC filtered): libc.so.6 libcrypto.so.10 libcrypto.so.10(libcrypto.so.10) libpthread.so.0 libssl.so.10 libssl.so.10(libssl.so.10) rtld(GNU_HASH) Provides -------- mongo-tools: mongo-tools mongo-tools(x86-32) Source checksums ---------------- https://github.com/mongodb/mongo/raw/6201872043ecbbc0a4cc169b5482dcf385fc464f/APACHE-2.0.txt : CHECKSUM(SHA256) this package : cfc7749b96f63bd31c3c42b5c471bf756814053e847c10f3eb003417bc523d30 CHECKSUM(SHA256) upstream package : cfc7749b96f63bd31c3c42b5c471bf756814053e847c10f3eb003417bc523d30 https://github.com/mongodb/mongo/raw/6201872043ecbbc0a4cc169b5482dcf385fc464f/debian/mongodump.1 : CHECKSUM(SHA256) this package : 1613f0806a88a26a12eb8ba9f83288b3b066d861bc7f306ea7ee4b1f9967dc25 CHECKSUM(SHA256) upstream package : 1613f0806a88a26a12eb8ba9f83288b3b066d861bc7f306ea7ee4b1f9967dc25 https://github.com/mongodb/mongo/raw/6201872043ecbbc0a4cc169b5482dcf385fc464f/debian/mongoexport.1 : CHECKSUM(SHA256) this package : 8a8c01a0bc75a79a8457006bb00433a335ee26606b7517d13d14126ef0b8f8ff CHECKSUM(SHA256) upstream package : 8a8c01a0bc75a79a8457006bb00433a335ee26606b7517d13d14126ef0b8f8ff https://github.com/mongodb/mongo-tools/archive/r3.0.3.tar.gz : CHECKSUM(SHA256) this package : 17deff3d1adf2b456b3d4dc6096e6d0ff4b0d4dd799adcdb3c64f12acfa3204f CHECKSUM(SHA256) upstream package : 17deff3d1adf2b456b3d4dc6096e6d0ff4b0d4dd799adcdb3c64f12acfa3204f https://github.com/mongodb/mongo/raw/6201872043ecbbc0a4cc169b5482dcf385fc464f/debian/bsondump.1 : CHECKSUM(SHA256) this package : 97068355d15cdb3372f6d4b08c43f0a7cb106f138934d1739f931f85b1a1fec1 CHECKSUM(SHA256) upstream package : 97068355d15cdb3372f6d4b08c43f0a7cb106f138934d1739f931f85b1a1fec1 https://github.com/mongodb/mongo/raw/6201872043ecbbc0a4cc169b5482dcf385fc464f/debian/mongooplog.1 : CHECKSUM(SHA256) this package : ae984fa81e2020bb57a134efca38d092c76b9e73dfc20515832d731306aaac79 CHECKSUM(SHA256) upstream package : ae984fa81e2020bb57a134efca38d092c76b9e73dfc20515832d731306aaac79 https://github.com/mongodb/mongo/raw/6201872043ecbbc0a4cc169b5482dcf385fc464f/debian/mongorestore.1 : CHECKSUM(SHA256) this package : b8dd3f5e23f342c6770f1121211b4a0337c27f37e93d561318262552f7418edd CHECKSUM(SHA256) upstream package : b8dd3f5e23f342c6770f1121211b4a0337c27f37e93d561318262552f7418edd https://github.com/mongodb/mongo/raw/6201872043ecbbc0a4cc169b5482dcf385fc464f/debian/mongofiles.1 : CHECKSUM(SHA256) this package : b31419710f0cf64c7ca054b5a77b6de569787fe21c97eae0f4be701eb1534199 CHECKSUM(SHA256) upstream package : b31419710f0cf64c7ca054b5a77b6de569787fe21c97eae0f4be701eb1534199 https://github.com/mongodb/mongo/raw/6201872043ecbbc0a4cc169b5482dcf385fc464f/debian/mongoimport.1 : CHECKSUM(SHA256) this package : 9ae3e9391b178e17ec54b23427037c9a6a0a6773c547229b1c36972a534139dd CHECKSUM(SHA256) upstream package : 9ae3e9391b178e17ec54b23427037c9a6a0a6773c547229b1c36972a534139dd https://github.com/mongodb/mongo/raw/6201872043ecbbc0a4cc169b5482dcf385fc464f/debian/mongostat.1 : CHECKSUM(SHA256) this package : bda96237683a96239fde869a543da2e4dcb265d775a8af88ce244a53d2cea6a3 CHECKSUM(SHA256) upstream package : bda96237683a96239fde869a543da2e4dcb265d775a8af88ce244a53d2cea6a3 https://github.com/mongodb/mongo/raw/6201872043ecbbc0a4cc169b5482dcf385fc464f/debian/mongotop.1 : CHECKSUM(SHA256) this package : 212b675e88891fb675cdc4947a997d7e410e3042278ac7dd476a121bcb466b9d CHECKSUM(SHA256) upstream package : 212b675e88891fb675cdc4947a997d7e410e3042278ac7dd476a121bcb466b9d Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review -vpn mongo-tools -m fedora-rawhide-i386 Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review