https://bugzilla.redhat.com/show_bug.cgi?id=1214385 --- Comment #4 from Marek Skalický <mskalick@xxxxxxxxxx> --- (In reply to gil cattaneo from comment #3) > (In reply to Marek Skalický from comment #2) > > Blocking: > > > > [!]: Package obeys FHS, except libexecdir and /usr/target. > > - jj2000.noarch: W: only-non-binary-in-usr-lib > > > > jj2000 should use %{_javadir} — /usr/share/java > /usr/lib/java/jj2000.jar > > ("Directory that holds all JAR files that do not contain or use native > > code and do not depend on a particular Java standard version. JAR files can > > either be placed directly in this directory or one of its subdirectories. > > Often packages create their own subdirectories there, in this case > > subdirectory name should match package name.") > is not applicable for this library > see > https://fedoraproject.org/wiki/Packaging: > Java#Packaging_JAR_files_that_use_JNI > this library use some classes for use/load native libraries But I think these used classes should be in /usr/lib/java, not your class. I haven't found it in packaging guidelines, but in my opinion JAR file use JNI when it directly call native library. I've looked into fedora how another packages do it and for example first what I've found is dbus-java, which requires JNI package libmatthew-java, but still use /usr/share/java. I know it is not any proof, but we can ask on devel list. > > > > Non blocking: > > > > [!]: If the source package does not include license text(s) as a separate > > file > > from upstream, the packager SHOULD query upstream to include it. > > > I also recommend to remove "This is a dependency for support of compression > > in Grib2 files in > > netCDF-java and TDS (https://github.com/Unidata/thredds). > > " from description. Because in Fedora this package can be used by other > > projects/programs too. But it is only my feeling... > > There are several projects that use a customized version of this library. > This clarification should be understood that probably, this fork may not be > suitable for other projects. > > Thanks! OK. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review