[Bug 1215046] Review Request: python-gear - Pure Python Async Gear Protocol Library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1215046



--- Comment #2 from Fabien Boucher <fboucher@xxxxxxxxxx> ---
Hi Pranav, thanks for the review.

I've updated the spec file and src.rpm.

https://ca.enocloud.com:8080/v1/AUTH_b57314058a4e42dabffc8cde6ccbf2de/fedora-packaging/python-gear.spec
https://ca.enocloud.com:8080/v1/AUTH_b57314058a4e42dabffc8cde6ccbf2de/fedora-packaging/python-gear-0.5.5-0.fc21.src.rpm

I no longer rely on a specific git ref but on the last tagged version available
on pypi. The tag is a bit old but recently, gear has been tagged 0.5.6 and it's
a matter of time this version is available on pypi too.

Regarding python[2|3]-devel in BuildRequires section I think only python2-devel
is needed indeed AFAIK python-gear does not include any python 3 files.

I removed the commented commands. A missing dependency to sphinx make the doc
building impossible.

About the eggs-info directory maybe I'm wrong but here
http://fedoraproject.org/wiki/Packaging:Python#Files_to_include it is mentioned
to keep it.

I removed the %clean section.

Cheers,
Fabien

Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=9678302

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]