[Bug 1215046] Review Request: python-gear - Pure Python Async Gear Protocol Library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1215046

Pranav Kant <pranav913@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pranav913@xxxxxxxxx



--- Comment #1 from Pranav Kant <pranav913@xxxxxxxxx> ---
Just a quick informal review.

* You need either python2-devel or python3-devel in BR. See:
http://fedoraproject.org/wiki/Packaging:Python#BuildRequires

* You have some commented out commands in %build section. Either use them or
remove them.

* Binary eggs must be removed in %prep section; remove .egg-info files.

* You don't need %clean section. Fedora handles it for you.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]