https://bugzilla.redhat.com/show_bug.cgi?id=1196780 --- Comment #2 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- fedora-review has the following to say: - Permissions on files are set properly. Note: See rpmlint output See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /var/tmp/1196780-openrpt/diff.txt See: http://fedoraproject.org/wiki/Packaging/SourceURL - Package uses either %{buildroot} or $RPM_BUILD_ROOT Note: Using both %{buildroot} and $RPM_BUILD_ROOT See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros - Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) openrpt-devel.x86_64: W: spurious-executable-perm /usr/include/openrpt/**.h openrpt-devel.x86_64: E: wrong-script-end-of-line-encoding /usr/include/openrpt/OpenRPT/wrtembed/tmp/ui_texteditor.h openrpt-devel.x86_64: E: wrong-script-end-of-line-encoding /usr/include/openrpt/OpenRPT/wrtembed/tmp/ui_crosstabeditor.h openrpt.src:47: W: macro-in-comment %{buildroot} openrpt.src: W: file-size-mismatch v3.3.7.tar.gz = 1218978, https://github.com/xtuple/openrpt/archive/v3.3.7.tar.gz = 1198328 openrpt-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libopenrptcommon.so.1.0.0 /lib64/libpthread.so.0 openrpt-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libopenrptcommon.so.1.0.0 /lib64/libm.so.6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review