[Bug 1196780] Review Request: openrpt - reporting tool for xTuple / PostBooks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1196780

Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |zbyszek@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |zbyszek@xxxxxxxxx
              Flags|                            |fedora-review?



--- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
# make install doesn't do anything for this qmake project so we do
# the installs manually
#make INSTALL_ROOT=%{buildroot} install
rm -f %{buildroot}%{_libdir}/lib*.a
rm -f %{buildroot}%{_libdir}/lib*.la
^^^ this looks like an oversight, presumably there's nothing to delete yet.

Why is ldconfig in %post needed for the main package?

%clean can probably be dropped.

Use %license for COPYING
(https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text).

Suggestion: use the name of the main package for docs and license dirs:
%global _docdir_fmt %{name}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]