Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: archivemail - A tool for archiving and compressing old email in mailboxes https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240877 ------- Additional Comments From faucamp@xxxxxxxxxx 2007-05-23 09:48 EST ------- (In reply to comment #7) > That didn't work, it said it needed archivemail to be called archivemail.py. > When I renamed it that, it still failed, with a whole slew of errors. It works just fine. Your "slew of errors" all have to do with the file location and execution permission of the archivemail.py file. Comment #5 was just an _example_. You still need to patch both archivemail.py (one-liner) and test_archive.py (one-liner + simple sed substitution) to work with these new file locations and permissions. I'll attach example patches shortly. > Spec URL: http://zanoni.jcomserv.net/fedora/archivemail/archivemail.spec > SRPM URL: http://zanoni.jcomserv.net/fedora/archivemail/archivemail-0.7.0-1.src.rpm > > Maybe it'd be better just to put the test_archivemail in /usr/bin with > archivemail.py and be done with it? No. One of the main tasks of a package maintainer is to make sure their packages integrate well with the rest of the distribution; anyone armed with google can roll their own RPMs, but that does not make them Fedora maintainers. Cluttering up /usr/bin with pointless symlinks is bad. Also, in general your average end-user isn't interested in unittests; I'm not even convinced they should be shipped in the binary RPM... but putting them under %docs at least gives intereste people (aka developers) the option of using them, I suppose. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review