https://bugzilla.redhat.com/show_bug.cgi?id=1210753 Petr Lautrbach <plautrba@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(plautrba@redhat.c | |om) | --- Comment #12 from Petr Lautrbach <plautrba@xxxxxxxxxx> --- (In reply to Daniel Kopeček from comment #11) > (In reply to Michael Schwendt (Fedora Packager Sponsors Group) from comment > #10) > > > spdlog-0-3.20150410git.211ce99.fc20.src.rpm > > > > One dot too much after "git": > > https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages > > It's already packaged and submitted. Given that: > > 1) the package passed the review > 2) there are other packages that use this form of snapshot version syntax > > I don't think it an issue worth fixing. Does it break something? Setting > needinfo on the reviewer to hear his opinion on this. > For the case of consistence with packaging guidelines, you should probably fix it even though I don't think it's against the rules as it is. The fix should not break anything since for rpm it doesn't really matter: $ rpmdev-vercmp 0-3.20150410git.211ce99.fc20 0-3.20150410git211ce99.fc20 0-3.20150410git.211ce99.fc20 == 0-3.20150410git211ce99.fc20 I'd just change this with the next update. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review