https://bugzilla.redhat.com/show_bug.cgi?id=1215478 Xavier Bachelot <xavier@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |xavier@xxxxxxxxxxxx --- Comment #1 from Xavier Bachelot <xavier@xxxxxxxxxxxx> --- Hi, Some comments on the spec : - If you're not using %{python_sitearch} don't define it at all. Also, this is probably only needed on older Fedora or EPEL, as these macros are provided by the python-devel package. Adjust depending on what distro/releases you are targeting. - Version looks like a git hash rather than a proper version. Maybe you should just use 0 as the version until upstream makes a proper release and move the git hash to the release tag. - Summary is too long and should not re-state the name of the package. - Fix License tag. The code seems to be mostly licensed under ASL, only part of it is MIT. - Source0 must be a full URL or you need to provide a script that can regenerate the tarball from the SCM. - Remove "Description:" from the start of the %description section. - In the %install section, cleaning the build root is not needed anymore. - In the %files section, there is no file marked as %doc. If that really is the case, remove the line, but I suspect you'd rather add some. - No license file included. - The changelog line is missing the version and release of the package. Regards, Xavier -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review